mbox series

[v4,0/5] Some improvements of resctrl selftest

Message ID 20221117010541.1014481-1-tan.shaopeng@jp.fujitsu.com (mailing list archive)
Headers show
Series Some improvements of resctrl selftest | expand

Message

Shaopeng Tan Nov. 17, 2022, 1:05 a.m. UTC 
Hello,

The aim of this patch series is to improve the resctrl selftest.
Without these fixes, some unnecessary processing will be executed
and test results will be confusing. 
There is no behavior change in test themselves.

[patch 1] Make write_schemata() run to set up shemata with 100% allocation
	  on first run in MBM test.
[patch 2] The MBA test result message is always output as "ok",
	  make output message to be "not ok" if MBA check result is failed.
[patch 3] When a child process is created by fork(), the buffer of the 
	  parent process is also copied. Flush the buffer before
	  executing fork().
[patch 4] Add a signal handler to cleanup properly before exiting the 
	  parent process if there is an error occurs after creating 
	  a child process with fork() in the CAT test.
[patch 5] Before exiting each test CMT/CAT/MBM/MBA, clear test result 
	  files function cat/cmt/mbm/mba_test_cleanup() are called
	  twice. Delete once.

This patch series is based on Linux v6.1-rc5

Difference from v3:
[patch 2] 
	Rename "failed" to "ret" to avoid confusion.
[patch 4] 
	- Use sigaction(2) instead of signal().
	- Add a description of using global bm_pid in commit message.
	- Add comments to clarify why let the child continue to its
	  infinite loop after the write() failed.
[patch 5] 
	Ensure to run cat/cmt/mbm/mba_test_cleanup() to clear test result 
	file before return if an error occurs.


Pervious versions of this series:
[v1] https://lore.kernel.org/lkml/20220914015147.3071025-1-tan.shaopeng@jp.fujitsu.com/
[v2] https://lore.kernel.org/lkml/20221005013933.1486054-1-tan.shaopeng@jp.fujitsu.com/
[v3] https://lore.kernel.org/lkml/20221101094341.3383073-1-tan.shaopeng@jp.fujitsu.com/

Shaopeng Tan (5):
  selftests/resctrl: Fix set up schemata with 100% allocation on first
    run in MBM test
  selftests/resctrl: Return MBA check result and make it to output
    message
  selftests/resctrl: Flush stdout file buffer before executing fork()
  selftests/resctrl: Cleanup properly when an error occurs in CAT test
  selftests/resctrl: Remove duplicate codes that clear each test result
    file

 tools/testing/selftests/resctrl/cat_test.c    | 31 +++++++++++++------
 tools/testing/selftests/resctrl/cmt_test.c    |  7 ++---
 tools/testing/selftests/resctrl/mba_test.c    | 23 +++++++-------
 tools/testing/selftests/resctrl/mbm_test.c    | 20 ++++++------
 .../testing/selftests/resctrl/resctrl_tests.c |  4 ---
 tools/testing/selftests/resctrl/resctrl_val.c |  1 +
 tools/testing/selftests/resctrl/resctrlfs.c   |  5 ++-
 7 files changed, 50 insertions(+), 41 deletions(-)