mbox series

[RESEND,v1,0/3] nolibc auxiliary vector retrieval support

Message ID 20230108135809.850210-1-ammar.faizi@intel.com (mailing list archive)
Headers show
Series nolibc auxiliary vector retrieval support | expand

Message

Ammar Faizi Jan. 8, 2023, 1:58 p.m. UTC 
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>

Hi Willy,

This series is a follow up of our previous discussion about getauxval()
and getpagesize() functions.

It will apply cleanly on top of your "20221227-nolibc-weak-4" branch.
Base commit: b6887ec8b0b0 ("tools/nolibc: add auxiliary vector
retrieval for mips").

I have added a selftest for the getpagesize() function, but I am not
sure how to assert the correctness of getauxval(). I think it is fine
not to add a selftest for getauxval(). If you think we should, please
give some advice on the test mechanism.

Thanks!

Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---

Ammar Faizi (3):
  nolibc/stdlib: Implement `getauxval(3)` function
  nolibc/sys: Implement `getpagesize(2)` function
  selftests/nolibc: Add `getpagesize(2)` selftest

 tools/include/nolibc/stdlib.h                | 27 ++++++++++++++++++
 tools/include/nolibc/sys.h                   | 21 ++++++++++++++
 tools/testing/selftests/nolibc/nolibc-test.c | 30 ++++++++++++++++++++
 3 files changed, 78 insertions(+)


base-commit: b6887ec8b0b0c78db414b78e329bf2ce234dedd5

Comments

Willy Tarreau Jan. 8, 2023, 5:15 p.m. UTC | #1 
Hi Ammar,

On Sun, Jan 08, 2023 at 08:58:06PM +0700, Ammar Faizi wrote:
> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> 
> Hi Willy,
> 
> This series is a follow up of our previous discussion about getauxval()
> and getpagesize() functions.
> 
> It will apply cleanly on top of your "20221227-nolibc-weak-4" branch.
> Base commit: b6887ec8b0b0 ("tools/nolibc: add auxiliary vector
> retrieval for mips").
> 
> I have added a selftest for the getpagesize() function, but I am not
> sure how to assert the correctness of getauxval(). I think it is fine
> not to add a selftest for getauxval(). If you think we should, please
> give some advice on the test mechanism.
(...)

Thank you! I've applied it to my local queue (will push soon), and
could test it on all supported archs and it works fine. Thus consider
it as merged now.

Thanks!
Willy