[net-next,v1,00/16] Device Memory TCP

Message

Mina Almasry Dec. 8, 2023, 12:52 a.m. UTC

Major changes in v1:
--------------

1. Implemented MVP queue API ndos to remove the userspace-visible
   driver reset.

2. Fixed issues in the napi_pp_put_page() devmem frag unref path.

3. Removed RFC tag.

Many smaller addressed comments across all the patches (patches have
individual change log).

Full tree including the rest of the GVE driver changes:
https://github.com/mina/linux/commits/tcpdevmem-v1

Cc: Yunsheng Lin <[e-mail]>
Cc: Shailend Chand <[e-mail]>
Cc: Harshitha Ramamurthy <[e-mail]>

Changes in RFC v3:
------------------

1. Pulled in the memory-provider dependency from Jakub's RFC[1] to make the
   series reviewable and mergable.

2. Implemented multi-rx-queue binding which was a todo in v2.

3. Fix to cmsg handling.

The sticking point in RFC v2[2] was the device reset required to refill
the device rx-queues after the dmabuf bind/unbind. The solution
suggested as I understand is a subset of the per-queue management ops
Jakub suggested or similar:

https://lore.kernel.org/netdev/[e-mail]/

This is not addressed in this revision, because:

1. This point was discussed at netconf & netdev and there is openness to
   using the current approach of requiring a device reset.

2. Implementing individual queue resetting seems to be difficult for my
   test bed with GVE. My prototype to test this ran into issues with the
   rx-queues not coming back up properly if reset individually. At the
   moment I'm unsure if it's a mistake in the POC or a genuine issue in
   the virtualization stack behind GVE, which currently doesn't test
   individual rx-queue restart.

3. Our usecases are not bothered by requiring a device reset to refill
   the buffer queues, and we'd like to support NICs that run into this
   limitation with resetting individual queues.

My thought is that drivers that have trouble with per-queue configs can
use the support in this series, while drivers that support new netdev
ops to reset individual queues can automatically reset the queue as
part of the dma-buf bind/unbind.

The same approach with device resets is presented again for consideration
with other sticking points addressed.

This proposal includes the rx devmem path only proposed for merge. For a
snapshot of my entire tree which includes the GVE POC page pool support &
device memory support:

https://github.com/torvalds/linux/compare/master...mina:linux:tcpdevmem-v3

[1] https://lore.kernel.org/netdev/[e-mail]/T/
[2] https://lore.kernel.org/netdev/[e-mail]/T/

Cc: Shakeel Butt <[e-mail]>
Cc: Jeroen de Borst <[e-mail]>
Cc: Praveen Kaligineedi <[e-mail]>

Changes in RFC v2:
------------------

The sticking point in RFC v1[1] was the dma-buf pages approach we used to
deliver the device memory to the TCP stack. RFC v2 is a proof-of-concept
that attempts to resolve this by implementing scatterlist support in the
networking stack, such that we can import the dma-buf scatterlist
directly. This is the approach proposed at a high level here[2].

Detailed changes:
1. Replaced dma-buf pages approach with importing scatterlist into the
   page pool.
2. Replace the dma-buf pages centric API with a netlink API.
3. Removed the TX path implementation - there is no issue with
   implementing the TX path with scatterlist approach, but leaving
   out the TX path makes it easier to review.
4. Functionality is tested with this proposal, but I have not conducted
   perf testing yet. I'm not sure there are regressions, but I removed
   perf claims from the cover letter until they can be re-confirmed.
5. Added Signed-off-by: contributors to the implementation.
6. Fixed some bugs with the RX path since RFC v1.

Any feedback welcome, but specifically the biggest pending questions
needing feedback IMO are:

1. Feedback on the scatterlist-based approach in general.
2. Netlink API (Patch 1 & 2).
3. Approach to handle all the drivers that expect to receive pages from
   the page pool (Patch 6).

[1] https://lore.kernel.org/netdev/[e-mail]/T/
[2] https://lore.kernel.org/netdev/CAHS8izPm6XRS54LdCDZVd0C75tA1zHSu6jLVO8nzTLXCc=[e-mail]/

----------------------

* TL;DR:

Device memory TCP (devmem TCP) is a proposal for transferring data to and/or
from device memory efficiently, without bouncing the data to a host memory
buffer.

* Problem:

A large amount of data transfers have device memory as the source and/or
destination. Accelerators drastically increased the volume of such transfers.
Some examples include:
- ML accelerators transferring large amounts of training data from storage into
  GPU/TPU memory. In some cases ML training setup time can be as long as 50% of
  TPU compute time, improving data transfer throughput & efficiency can help
  improving GPU/TPU utilization.

- Distributed training, where ML accelerators, such as GPUs on different hosts,
  exchange data among them.

- Distributed raw block storage applications transfer large amounts of data with
  remote SSDs, much of this data does not require host processing.

Today, the majority of the Device-to-Device data transfers the network are
implemented as the following low level operations: Device-to-Host copy,
Host-to-Host network transfer, and Host-to-Device copy.

The implementation is suboptimal, especially for bulk data transfers, and can
put significant strains on system resources, such as host memory bandwidth,
PCIe bandwidth, etc. One important reason behind the current state is the
kernel’s lack of semantics to express device to network transfers.

* Proposal:

In this patch series we attempt to optimize this use case by implementing
socket APIs that enable the user to:

1. send device memory across the network directly, and
2. receive incoming network packets directly into device memory.

Packet _payloads_ go directly from the NIC to device memory for receive and from
device memory to NIC for transmit.
Packet _headers_ go to/from host memory and are processed by the TCP/IP stack
normally. The NIC _must_ support header split to achieve this.

Advantages:

- Alleviate host memory bandwidth pressure, compared to existing
 network-transfer + device-copy semantics.

- Alleviate PCIe BW pressure, by limiting data transfer to the lowest level
  of the PCIe tree, compared to traditional path which sends data through the
  root complex.

* Patch overview:

** Part 1: netlink API

Gives user ability to bind dma-buf to an RX queue.

** Part 2: scatterlist support

Currently the standard for device memory sharing is DMABUF, which doesn't
generate struct pages. On the other hand, networking stack (skbs, drivers, and
page pool) operate on pages. We have 2 options:

1. Generate struct pages for dmabuf device memory, or,
2. Modify the networking stack to process scatterlist.

Approach #1 was attempted in RFC v1. RFC v2 implements approach #2.

** part 3: page pool support

We piggy back on page pool memory providers proposal:
https://github.com/kuba-moo/linux/tree/pp-providers

It allows the page pool to define a memory provider that provides the
page allocation and freeing. It helps abstract most of the device memory
TCP changes from the driver.

** part 4: support for unreadable skb frags

Page pool iovs are not accessible by the host; we implement changes
throughput the networking stack to correctly handle skbs with unreadable
frags.

** Part 5: recvmsg() APIs

We define user APIs for the user to send and receive device memory.

Not included with this RFC is the GVE devmem TCP support, just to
simplify the review. Code available here if desired:
https://github.com/mina/linux/tree/tcpdevmem

This RFC is built on top of net-next with Jakub's pp-providers changes
cherry-picked.

* NIC dependencies:

1. (strict) Devmem TCP require the NIC to support header split, i.e. the
   capability to split incoming packets into a header + payload and to put
   each into a separate buffer. Devmem TCP works by using device memory
   for the packet payload, and host memory for the packet headers.

2. (optional) Devmem TCP works better with flow steering support & RSS support,
   i.e. the NIC's ability to steer flows into certain rx queues. This allows the
   sysadmin to enable devmem TCP on a subset of the rx queues, and steer
   devmem TCP traffic onto these queues and non devmem TCP elsewhere.

The NIC I have access to with these properties is the GVE with DQO support
running in Google Cloud, but any NIC that supports these features would suffice.
I may be able to help reviewers bring up devmem TCP on their NICs.

* Testing:

The series includes a udmabuf kselftest that show a simple use case of
devmem TCP and validates the entire data path end to end without
a dependency on a specific dmabuf provider.

** Test Setup

Kernel: net-next with this RFC and memory provider API cherry-picked
locally.

Hardware: Google Cloud A3 VMs.

NIC: GVE with header split & RSS & flow steering support.

Jakub Kicinski (2):
  net: page_pool: factor out releasing DMA from releasing the page
  net: page_pool: create hooks for custom page providers

Mina Almasry (14):
  queue_api: define queue api
  gve: implement queue api
  net: netdev netlink api to bind dma-buf to a net device
  netdev: support binding dma-buf to netdevice
  netdev: netdevice devmem allocator
  memory-provider: dmabuf devmem memory provider
  page_pool: device memory support
  page_pool: don't release iov on elevanted refcount
  net: support non paged skb frags
  net: add support for skbs with unreadable frags
  tcp: RX path for devmem TCP
  net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags
  net: add devmem TCP documentation
  selftests: add ncdevmem, netcat for devmem TCP

 Documentation/netlink/specs/netdev.yaml      |  52 ++
 Documentation/networking/devmem.rst          | 270 ++++++++++
 drivers/net/ethernet/google/gve/gve_adminq.c |   6 +-
 drivers/net/ethernet/google/gve/gve_adminq.h |   3 +
 drivers/net/ethernet/google/gve/gve_dqo.h    |   2 +
 drivers/net/ethernet/google/gve/gve_main.c   | 286 +++++++++++
 drivers/net/ethernet/google/gve/gve_rx_dqo.c |   5 +-
 include/linux/netdevice.h                    |  24 +
 include/linux/skbuff.h                       |  56 ++-
 include/linux/socket.h                       |   1 +
 include/net/devmem.h                         | 109 +++++
 include/net/netdev_rx_queue.h                |   1 +
 include/net/page_pool/helpers.h              | 162 +++++-
 include/net/page_pool/types.h                |  48 ++
 include/net/sock.h                           |   2 +
 include/net/tcp.h                            |   5 +-
 include/uapi/asm-generic/socket.h            |   6 +
 include/uapi/linux/netdev.h                  |  19 +
 include/uapi/linux/uio.h                     |  14 +
 net/core/datagram.c                          |   6 +
 net/core/dev.c                               | 314 +++++++++++-
 net/core/gro.c                               |   7 +-
 net/core/netdev-genl-gen.c                   |  19 +
 net/core/netdev-genl-gen.h                   |   2 +
 net/core/netdev-genl.c                       | 124 +++++
 net/core/page_pool.c                         | 239 +++++++--
 net/core/skbuff.c                            | 108 +++-
 net/core/sock.c                              |  38 ++
 net/ipv4/tcp.c                               | 196 +++++++-
 net/ipv4/tcp_input.c                         |  13 +-
 net/ipv4/tcp_ipv4.c                          |   8 +
 net/ipv4/tcp_output.c                        |   5 +-
 net/packet/af_packet.c                       |   4 +-
 tools/include/uapi/linux/netdev.h            |  19 +
 tools/testing/selftests/net/.gitignore       |   1 +
 tools/testing/selftests/net/Makefile         |   5 +
 tools/testing/selftests/net/ncdevmem.c       | 489 +++++++++++++++++++
 37 files changed, 2585 insertions(+), 83 deletions(-)
 create mode 100644 Documentation/networking/devmem.rst
 create mode 100644 include/net/devmem.h
 create mode 100644 tools/testing/selftests/net/ncdevmem.c

Comments

Mina Almasry Dec. 8, 2023, 1:47 a.m. UTC | #1

On Thu, Dec 7, 2023 at 4:52 PM Mina Almasry <[e-mail]> wrote:
>
> Major changes in v1:
> --------------
>
> 1. Implemented MVP queue API ndos to remove the userspace-visible
>    driver reset.
>
> 2. Fixed issues in the napi_pp_put_page() devmem frag unref path.
>
> 3. Removed RFC tag.
>
> Many smaller addressed comments across all the patches (patches have
> individual change log).
>
> Full tree including the rest of the GVE driver changes:
> https://github.com/mina/linux/commits/tcpdevmem-v1
>
> Cc: Yunsheng Lin <[e-mail]>
> Cc: Shailend Chand <[e-mail]>
> Cc: Harshitha Ramamurthy <[e-mail]>
>

Welp, I messed up the subject line. It should say [PATCH net-next...]
across all the patches. This may trip up bots and email filters. If
this is annoying, I'll resend with the fixed subject line after the
24hr cooldown period. Sorry about that.

David Ahern Dec. 8, 2023, 5:57 p.m. UTC | #2

On 12/7/23 5:52 PM, Mina Almasry wrote:
> Major changes in v1:
> --------------
> 
> 1. Implemented MVP queue API ndos to remove the userspace-visible
>    driver reset.
> 
> 2. Fixed issues in the napi_pp_put_page() devmem frag unref path.
> 
> 3. Removed RFC tag.
> 
> Many smaller addressed comments across all the patches (patches have
> individual change log).
> 
> Full tree including the rest of the GVE driver changes:
> https://github.com/mina/linux/commits/tcpdevmem-v1
> 

Still a lot of DEVMEM references (e.g., socket API). Any reason not to
move those to DMABUF?

Mina Almasry Dec. 8, 2023, 7:31 p.m. UTC | #3

On Fri, Dec 8, 2023 at 9:57 AM David Ahern <[e-mail]> wrote:
>
> On 12/7/23 5:52 PM, Mina Almasry wrote:
> > Major changes in v1:
> > --------------
> >
> > 1. Implemented MVP queue API ndos to remove the userspace-visible
> >    driver reset.
> >
> > 2. Fixed issues in the napi_pp_put_page() devmem frag unref path.
> >
> > 3. Removed RFC tag.
> >
> > Many smaller addressed comments across all the patches (patches have
> > individual change log).
> >
> > Full tree including the rest of the GVE driver changes:
> > https://github.com/mina/linux/commits/tcpdevmem-v1
> >
>
> Still a lot of DEVMEM references (e.g., socket API). Any reason not to
> move those to DMABUF?
>

In my mind the naming (maybe too silly/complicated, feel free to correct) is:

The feature is devmem TCP because we really care about TCPing into
device memory. So the uapi/feature name retains devmem.

dmabuf is the abstraction for devmem that we use. In theory someone
can come up with a driver that doesn't like dmabuf and uses something
else instead, and the devmem TCP support can be extended to support
that something else. Functions that handle specifically dmabuf and are
not generic to support general devmem are named accordingly
(netdev_alloc_dmabuf/netdev_free_dmabuf)

page_pool_iov is a generic type to support generic non-paged memory,
functions that are supposed to handle any generic non-paged memory and
named accordingly (page_pool_iov_get_many).

Shakeel Butt Dec. 10, 2023, 3:48 a.m. UTC | #4

On Thu, Dec 07, 2023 at 04:52:31PM -0800, Mina Almasry wrote:
[...]
> 
> Today, the majority of the Device-to-Device data transfers the network are

'the network' in above can be removed.

> implemented as the following low level operations: Device-to-Host copy,
> Host-to-Host network transfer, and Host-to-Device copy.
> 

[...]

> 
> ** Part 5: recvmsg() APIs
> 
> We define user APIs for the user to send and receive device memory.
> 
> Not included with this RFC is the GVE devmem TCP support, just to

no more RFC

> simplify the review. Code available here if desired:
> https://github.com/mina/linux/tree/tcpdevmem
> 
> This RFC is built on top of net-next with Jakub's pp-providers changes

no more RFC

[...]
> 
> ** Test Setup
> 
> Kernel: net-next with this RFC and memory provider API cherry-picked

no more RFC

> locally.
> 
> Hardware: Google Cloud A3 VMs.
> 
> NIC: GVE with header split & RSS & flow steering support.
>

Christoph Hellwig Dec. 12, 2023, 5:58 a.m. UTC | #5

Please don't spread scatterlists further.  They are a bad data structure
that mix input data (page, offset, len) and output data (phys_addr,
dma_offset, dma_len), and do in a horrible way for iommmu mappings that
can coalesce.  Jason and coworkers have been looking into the long
overdue API to better support batch mapping of better data structures,
and this is a prime example of new code that should be using.

[e-mail] Dec. 14, 2023, 6:20 a.m. UTC | #6

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Thu,  7 Dec 2023 16:52:31 -0800 you wrote:
> Major changes in v1:
> --------------
> 
> 1. Implemented MVP queue API ndos to remove the userspace-visible
>    driver reset.
> 
> 2. Fixed issues in the napi_pp_put_page() devmem frag unref path.
> 
> [...]

Here is the summary with links:
  - [net-next,v1,01/16] net: page_pool: factor out releasing DMA from releasing the page
    https://git.kernel.org/netdev/net-next/c/c3f687d8dfeb
  - [net-next,v1,02/16] net: page_pool: create hooks for custom page providers
    (no matching commit)
  - [net-next,v1,03/16] queue_api: define queue api
    (no matching commit)
  - [net-next,v1,04/16] gve: implement queue api
    (no matching commit)
  - [net-next,v1,05/16] net: netdev netlink api to bind dma-buf to a net device
    (no matching commit)
  - [net-next,v1,06/16] netdev: support binding dma-buf to netdevice
    (no matching commit)
  - [net-next,v1,07/16] netdev: netdevice devmem allocator
    (no matching commit)
  - [net-next,v1,08/16] memory-provider: dmabuf devmem memory provider
    (no matching commit)
  - [net-next,v1,09/16] page_pool: device memory support
    (no matching commit)
  - [net-next,v1,10/16] page_pool: don't release iov on elevanted refcount
    (no matching commit)
  - [net-next,v1,11/16] net: support non paged skb frags
    (no matching commit)
  - [net-next,v1,12/16] net: add support for skbs with unreadable frags
    (no matching commit)
  - [net-next,v1,13/16] tcp: RX path for devmem TCP
    (no matching commit)
  - [net-next,v1,14/16] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags
    (no matching commit)
  - [net-next,v1,15/16] net: add devmem TCP documentation
    (no matching commit)
  - [net-next,v1,16/16] selftests: add ncdevmem, netcat for devmem TCP
    (no matching commit)

You are awesome, thank you!

Christoph Hellwig Dec. 14, 2023, 6:48 a.m. UTC | #7

On Thu, Dec 14, 2023 at 06:20:27AM +0000, [e-mail] wrote:
> Hello:
> 
> This series was applied to netdev/net-next.git (main)
> by Jakub Kicinski <[e-mail]>:

Umm, this is still very broken in intraction with other subsystems.
Please don't push ahead so quickly.

Mina Almasry Dec. 14, 2023, 6:51 a.m. UTC | #8

On Wed, Dec 13, 2023 at 10:49 PM Christoph Hellwig <[e-mail]> wrote:
>
> On Thu, Dec 14, 2023 at 06:20:27AM +0000, [e-mail] wrote:
> > Hello:
> >
> > This series was applied to netdev/net-next.git (main)
> > by Jakub Kicinski <[e-mail]>:
>
> Umm, this is still very broken in intraction with other subsystems.
> Please don't push ahead so quickly.
>

The bot is just a bit optimistic. Only this first patch was applied.
It does not interact with other subsystems.

  - [net-next,v1,01/16] net: page_pool: factor out releasing DMA from
releasing the page

Christoph Hellwig Dec. 14, 2023, 6:59 a.m. UTC | #9

On Wed, Dec 13, 2023 at 10:51:25PM -0800, Mina Almasry wrote:
> On Wed, Dec 13, 2023 at 10:49 PM Christoph Hellwig <[e-mail]> wrote:
> >
> > On Thu, Dec 14, 2023 at 06:20:27AM +0000, [e-mail] wrote:
> > > Hello:
> > >
> > > This series was applied to netdev/net-next.git (main)
> > > by Jakub Kicinski <[e-mail]>:
> >
> > Umm, this is still very broken in intraction with other subsystems.
> > Please don't push ahead so quickly.
> >
> 
> The bot is just a bit optimistic. Only this first patch was applied.
> It does not interact with other subsystems.
> 
>   - [net-next,v1,01/16] net: page_pool: factor out releasing DMA from
> releasing the page

Ah, that makes sense.  Thanks for the update!