mbox series

[net-next,v7,0/3] net: gro: move p->{flush/flush_id} calculations to L4

Message ID 20240412155533.115507-1-richardbgobert@gmail.com (mailing list archive)
Headers show
Series net: gro: move p->{flush/flush_id} calculations to L4 | expand

Message

Richard Gobert April 12, 2024, 3:55 p.m. UTC 
This patch series depends on commits in the series submitted to net.
(https://lore.kernel.org/netdev/20240412152120.115067-1-richardbgobert@gmail.com/)

The fields network_offset and inner_network_offset are added to
napi_gro_cb, and are both set during the receive phase of GRO. This is then
leveraged in the next commit to remove flush_id state from napi_gro_cb, and
stateful code in {ipv6,inet}_gro_receive which may be unnecessarily
complicated due to encapsulation support in GRO.

3rd patch adds tests for different flush_id flows in GRO.

v6 -> v7:
 - Moved bug fixes to a separate submission in net
 - Added UDP fwd benchmark
 - v6:
   https://lore.kernel.org/all/20240410153423.107381-1-richardbgobert@gmail.com/

v5 -> v6:
 - Write inner_network_offset in vxlan and geneve
 - Ignore is_atomic when DF=0
 - v5:
   https://lore.kernel.org/all/20240408141720.98832-1-richardbgobert@gmail.com/

v4 -> v5:
 - Add 1st commit - flush id checks in udp_gro_receive segment which can be
   backported by itself
 - Add TCP measurements for the 5th commit
 - Add flush id tests to ensure flush id logic is preserved in GRO
 - Simplify gro_inet_flush by removing a branch
 - v4:
   https://lore.kernel.org/all/202420325182543.87683-1-richardbgobert@gmail.com/

v3 -> v4:
 - Fix code comment and commit message typos
 - v3:
   https://lore.kernel.org/all/f939c84a-2322-4393-a5b0-9b1e0be8ed8e@gmail.com/

v2 -> v3:
 - Use napi_gro_cb instead of skb->{offset}
 - v2:
   https://lore.kernel.org/all/2ce1600b-e733-448b-91ac-9d0ae2b866a4@gmail.com/

v1 -> v2:
 - Pass p_off in *_gro_complete to fix UDP bug
 - Remove more conditionals and memory fetches from inet_gro_flush
 - v1:
   https://lore.kernel.org/netdev/e1d22505-c5f8-4c02-a997-64248480338b@gmail.com/

Richard Gobert (3):
  net: gro: add {inner_}network_offset to napi_gro_cb
  net: gro: move L3 flush checks to tcp_gro_receive and udp_gro_receive_segment
  selftests/net: add flush id selftests

 drivers/net/geneve.c              |   1 +
 drivers/net/vxlan/vxlan_core.c    |   1 +
 include/net/gro.h                 |  82 +++++++++++++++--
 net/8021q/vlan_core.c             |   2 +
 net/core/gro.c                    |   5 +-
 net/ethernet/eth.c                |   1 +
 net/ipv4/af_inet.c                |  46 +---------
 net/ipv4/gre_offload.c            |   1 +
 net/ipv4/tcp_offload.c            |  15 +---
 net/ipv4/udp_offload.c            |  16 +---
 net/ipv6/ip6_offload.c            |  19 +---
 tools/testing/selftests/net/gro.c | 144 ++++++++++++++++++++++++++++++
 12 files changed, 238 insertions(+), 95 deletions(-)