mbox series

[0/2] tools/nolibc: implement strtol() and friends

Message ID 20240425-nolibc-strtol-v1-0-bfeef7846902@weissschuh.net (mailing list archive)
Headers show
Series tools/nolibc: implement strtol() and friends | expand

Message

Thomas Weißschuh April 25, 2024, 4:09 p.m. UTC
I wanted to implement sscanf() for ksft_min_kernel_version() and this is
a prerequisite for it.

It's also useful on its own so it gets its own submission.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (2):
      tools/nolibc: add limits for {u,}intmax_t, ulong and {u,}llong
      tools/nolibc: implement strtol() and friends

 tools/include/nolibc/stdint.h                |  19 +++++
 tools/include/nolibc/stdlib.h                | 109 +++++++++++++++++++++++++++
 tools/testing/selftests/nolibc/nolibc-test.c |  59 +++++++++++++++
 3 files changed, 187 insertions(+)
---
base-commit: f1652790cd374bcf98efc913ec69ed18d20e7747
change-id: 20240415-nolibc-strtol-af77a1f2c766

Best regards,

Comments

Willy Tarreau April 25, 2024, 4:30 p.m. UTC | #1
Hi again Thomas,

On Thu, Apr 25, 2024 at 06:09:25PM +0200, Thomas Weißschuh wrote:
> I wanted to implement sscanf() for ksft_min_kernel_version() and this is
> a prerequisite for it.
> 
> It's also useful on its own so it gets its own submission.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Nice work, thank you. For the whole series, modulo my small comments on
2/2:

  Acked-by: Willy Tarreau <w@1wt.eu>

Cheers,
willy
Thomas Weißschuh April 25, 2024, 8:30 p.m. UTC | #2
On 2024-04-25 18:30:39+0000, Willy Tarreau wrote:
> Hi again Thomas,
> 
> On Thu, Apr 25, 2024 at 06:09:25PM +0200, Thomas Weißschuh wrote:
> > I wanted to implement sscanf() for ksft_min_kernel_version() and this is
> > a prerequisite for it.
> > 
> > It's also useful on its own so it gets its own submission.
> > 
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> 
> Nice work, thank you. For the whole series, modulo my small comments on
> 2/2:

Thanks for those great catches!

I addressed them and pushed the result to nolibc/next.

>   Acked-by: Willy Tarreau <w@1wt.eu>

Thomas