mbox series

[0/3] tools/nolibc: implement strerror()

Message ID 20240426-nolibc-strerror-v1-0-76a4c9c5271d@weissschuh.net (mailing list archive)
Headers show
Series tools/nolibc: implement strerror() | expand

Message

Thomas Weißschuh April 26, 2024, 11:08 a.m. UTC
Adds a simple implementation of strerror() and makes use of it in
kselftests.

Shuah, could you Ack patch 3?
Willy, this should work *without* your Ack.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (3):
      selftests/nolibc: introduce condition to run tests only on nolibc
      tools/nolibc: implement strerror()
      selftests: kselftest: also use strerror() on nolibc

 tools/include/nolibc/stdio.h                 | 10 ++++++++
 tools/testing/selftests/kselftest.h          |  8 -------
 tools/testing/selftests/nolibc/nolibc-test.c | 36 ++++++++++++++++++----------
 3 files changed, 33 insertions(+), 21 deletions(-)
---
base-commit: a3063ba97f31e0364379a3ffc567203e3f79e877
change-id: 20240425-nolibc-strerror-67f4bfa03035

Best regards,

Comments

Thomas Weißschuh May 2, 2024, 4:10 p.m. UTC | #1
Hi Shuah,

On 2024-04-26 13:08:55+0000, Thomas Weißschuh wrote:
> Adds a simple implementation of strerror() and makes use of it in
> kselftests.
> 
> Shuah, could you Ack patch 3?

Friendly ping for an Ack of patch 3 of this series.

After that I'd like to submit an updated nolibc pull request to you for 6.10.

> Willy, this should work *without* your Ack.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Thomas Weißschuh (3):
>       selftests/nolibc: introduce condition to run tests only on nolibc
>       tools/nolibc: implement strerror()
>       selftests: kselftest: also use strerror() on nolibc
> 
>  tools/include/nolibc/stdio.h                 | 10 ++++++++
>  tools/testing/selftests/kselftest.h          |  8 -------
>  tools/testing/selftests/nolibc/nolibc-test.c | 36 ++++++++++++++++++----------
>  3 files changed, 33 insertions(+), 21 deletions(-)
> ---
> base-commit: a3063ba97f31e0364379a3ffc567203e3f79e877
> change-id: 20240425-nolibc-strerror-67f4bfa03035
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@weissschuh.net>
Shuah Khan June 28, 2024, 9:46 p.m. UTC | #2
On 5/2/24 10:10, Thomas Weißschuh wrote:
> Hi Shuah,
> 
> On 2024-04-26 13:08:55+0000, Thomas Weißschuh wrote:
>> Adds a simple implementation of strerror() and makes use of it in
>> kselftests.
>>
>> Shuah, could you Ack patch 3?
> 
> Friendly ping for an Ack of patch 3 of this series.
> 
> After that I'd like to submit an updated nolibc pull request to you for 6.10.
> 
>> Willy, this should work *without* your Ack.
>>
>> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
>> ---
>> Thomas Weißschuh (3):
>>        selftests/nolibc: introduce condition to run tests only on nolibc
>>        tools/nolibc: implement strerror()
>>        selftests: kselftest: also use strerror() on nolibc
>>
>>   tools/include/nolibc/stdio.h                 | 10 ++++++++
>>   tools/testing/selftests/kselftest.h          |  8 -------
>>   tools/testing/selftests/nolibc/nolibc-test.c | 36 ++++++++++++++++++----------
>>   3 files changed, 33 insertions(+), 21 deletions(-)
>> ---
>> base-commit: a3063ba97f31e0364379a3ffc567203e3f79e877
>> change-id: 20240425-nolibc-strerror-67f4bfa03035
>>
>> Best regards,
>> -- 
>> Thomas Weißschuh <linux@weissschuh.net>

Sorry for the delay o this.

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah