From patchwork Fri Apr 26 17:22:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= X-Patchwork-Id: 13645210 Received: from smtp-8fad.mail.infomaniak.ch (smtp-8fad.mail.infomaniak.ch [83.166.143.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3330E145B0F for ; Fri, 26 Apr 2024 17:40:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.166.143.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714153248; cv=none; b=qvwr93RYWK1iOr0L9xmyAWf21jPpXoD9sW5Y0UotfBGNLSbZspAXch71Hv2fgdqEGgQ4qmeMaVznALLweYWTewYA3+/Hy4lra+gSuy282K6cEfatF+6x8/ckMUhafZuNLH1+qZadXFGzy3w4Rn29j4u/++w9y37zQ8lElf0HDjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714153248; c=relaxed/simple; bh=T+qvLdz7Xc/vYbDxHCVT4t2BwTarjFMD5whDaioo+Ag=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=b1Qzi3/Gq3JQoODJHteOfUZ9kedsLNQx32Se101fJ5D3G2lkpUnXhrFOlKwgLJ9hiTLaiQlSLhFr8vjDBb7Wd+bKTCLmZSEYCoPPo6bnqhIlv7fiWzR0SLAXRfxHXggcWO/ePa1526Iv4E5WWzZIeSkHwqmVsbVhQUMRkOXxIqA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net; spf=pass smtp.mailfrom=digikod.net; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b=Vf88SdYh; arc=none smtp.client-ip=83.166.143.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=digikod.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b="Vf88SdYh" Received: from smtp-4-0000.mail.infomaniak.ch (smtp-4-0000.mail.infomaniak.ch [10.7.10.107]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4VR0134W2qz608; Fri, 26 Apr 2024 19:23:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1714152183; bh=T+qvLdz7Xc/vYbDxHCVT4t2BwTarjFMD5whDaioo+Ag=; h=From:To:Cc:Subject:Date:From; b=Vf88SdYh/JXH5+V/CTkZpwdDnkYOazQwN+FUx+yqpnFbz1L9U1szO/Z/W+iy5pkLH vuAVA2zYaVjnwP7KQwLohhcg4hzoAPFgtDm+wOP7oUmDHlnbBqQ++R851l/qXIC9u+ qwX8ryBkCT/DeIhjUdOC6/FD++V8/a4KOO8q1ugI= Received: from unknown by smtp-4-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4VR0120m93zcqq; Fri, 26 Apr 2024 19:23:02 +0200 (CEST) From: =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= To: Christian Brauner , Jakub Kicinski , Kees Cook , Mark Brown , Shengyu Li , Shuah Khan Cc: =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= , "David S . Miller" , =?utf-8?q?G=C3=BCnther_Noack?= , Will Drewry , kernel test robot , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH v1 0/5] Fix Kselftest's vfork() side effects Date: Fri, 26 Apr 2024 19:22:47 +0200 Message-ID: <20240426172252.1862930-1-mic@digikod.net> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Infomaniak-Routing: alpha Hi, As reported by Kernel Test Robot [1], some pidfd tests fail. This is due to the use of vfork() which introduced some side effects. Similarly, while making it more generic, a previous commit made some Landlock file system tests flaky, and subject to the host's file system mount configuration. This series fixes all these side effects by replacing vfork() with clone3() and CLONE_VFORK, which is cleaner (no arbitrary shared memory) and makes the Kselftest framework more robust. I tried different approaches and I found this one to be the cleaner and less invasive for current test cases. I successfully ran the following tests (using TEST_F and fork/clone/clone3) with this series: - landlock:fs_test - landlock:net_test - landlock:ptrace_test - move_mount_set_group:move_mount_set_group_test - net/af_unix:scm_pidfd - perf_events:remove_on_exec - pidfd:pidfd_getfd_test - pidfd:pidfd_setns_test - seccomp:seccomp_bpf - user_events:abi_test [1] https://lore.kernel.org/oe-lkp/202403291015.1fcfa957-oliver.sang@intel.com Regards, Mickaël Salaün (5): selftests/pidfd: Fix config for pidfd_setns_test selftests/landlock: Fix FS tests when run on a private mount point selftests/harness: Fix fixture teardown selftests/harness: Fix interleaved scheduling leading to race conditions selftests/harness: Fix vfork() side effects and uncaught errors tools/testing/selftests/kselftest_harness.h | 113 +++++++++++++----- tools/testing/selftests/landlock/fs_test.c | 83 ++++++++----- tools/testing/selftests/pidfd/config | 2 + .../selftests/pidfd/pidfd_setns_test.c | 2 +- 4 files changed, 135 insertions(+), 65 deletions(-) base-commit: c942a0cd3603e34dd2d7237e064d9318cb7f9654