| Message ID | 20240610054129.1527389-1-usama.anjum@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | kselftests: vdso: conform tests to TAP output | expand |
On 6/9/24 23:41, Muhammad Usama Anjum wrote: > Conform individual tests to TAP output. One patch conform one test. With > this series, all vDSO tests become TAP conformant. > > First patch conform the test by using kselftest_harness.h. Other patches > are conforming using default kselftest.h helpers. > > All tests have been tested multiple times before and after these > patches. They are working correctly and outputting TAP messaging to find > failures quikly when they happen. > --- > Changes since v1: > - Update cover letter > - Update commit message of first patch > > Muhammad Usama Anjum (4): > kselftests: vdso: vdso_test_clock_getres: conform test to TAP output > kselftests: vdso: vdso_test_correctness: conform test to TAP output > kselftests: vdso: vdso_test_getcpu: conform test to TAP output > kselftests: vdso: vdso_test_gettimeofday: conform test to TAP output > > .../selftests/vDSO/vdso_test_clock_getres.c | 68 ++++---- > .../selftests/vDSO/vdso_test_correctness.c | 146 +++++++++--------- > .../testing/selftests/vDSO/vdso_test_getcpu.c | 16 +- > .../selftests/vDSO/vdso_test_gettimeofday.c | 23 +-- > 4 files changed, 126 insertions(+), 127 deletions(-) > I see two changes: - concvering this test to use kselftes_harness. I am not seeing a value to this. - Second converting every single print to TAP. This isn't necessary since the kselftest wrapper prints appropriate summary message based on the KSFT_ code I want to output before and after to assess the value of this change. TAP conversions make sense if and when they add value. thanks, -- Shuah
On 6/12/24 1:37 AM, Shuah Khan wrote: > On 6/9/24 23:41, Muhammad Usama Anjum wrote: >> Conform individual tests to TAP output. One patch conform one test. With >> this series, all vDSO tests become TAP conformant. >> >> First patch conform the test by using kselftest_harness.h. Other patches >> are conforming using default kselftest.h helpers. >> >> All tests have been tested multiple times before and after these >> patches. They are working correctly and outputting TAP messaging to find >> failures quikly when they happen. >> --- >> Changes since v1: >> - Update cover letter >> - Update commit message of first patch >> >> Muhammad Usama Anjum (4): >> kselftests: vdso: vdso_test_clock_getres: conform test to TAP output >> kselftests: vdso: vdso_test_correctness: conform test to TAP output >> kselftests: vdso: vdso_test_getcpu: conform test to TAP output >> kselftests: vdso: vdso_test_gettimeofday: conform test to TAP output >> >> .../selftests/vDSO/vdso_test_clock_getres.c | 68 ++++---- >> .../selftests/vDSO/vdso_test_correctness.c | 146 +++++++++--------- >> .../testing/selftests/vDSO/vdso_test_getcpu.c | 16 +- >> .../selftests/vDSO/vdso_test_gettimeofday.c | 23 +-- >> 4 files changed, 126 insertions(+), 127 deletions(-) >> > > I see two changes: > > - concvering this test to use kselftes_harness. I am not seeing a value to > this. > - Second converting every single print to TAP. This isn't necessary since the > kselftest wrapper prints appropriate summary message based on the KSFT_ code If a test prints standard output, only then CI and regression detection scripts identify if a test (and test case) was passed or failed. Or when it started failing. The attempt here to conform to TAP to get output which is recognizable and can easily be processed. > > I want to output before and after to assess the value of this change. TAP > conversions > make sense if and when they add value. Sure. Attaching before and after output for easy comparison. Please let me know about your thoughts. > > thanks, > -- Shuah >