mbox series

[bpf-next,v3,0/3] selftests/bpf: add coverage for xdp_features in test_progs

Message ID 20241009-convert_xdp_tests-v3-0-51cea913710c@bootlin.com (mailing list archive)
Headers show
Series selftests/bpf: add coverage for xdp_features in test_progs | expand

Message

Alexis Lothoré Oct. 9, 2024, 10:12 a.m. UTC
Hello,
this small series aims to increase coverage of xdp features in
test_progs. The initial versions proposed to rework test_xdp_features.sh
to make it fit in test_progs, but some discussions in v1 and v2 showed
that the script is still needed as a standalone tool. So this new
revision lets test_xdp_features.sh as-is, and rather adds missing
coverage in existing test (cpu map). The new revision is now also a
follow-up to the update performed by Florian Kauer in [1] for devmap
programs testing.

[1] https://lore.kernel.org/bpf/20240911-devel-koalo-fix-ingress-ifindex-v4-2-5c643ae10258@linutronix.de/

---
Changes in v3:
- Drop xdp_features rework commit
- update xdp_cpumap_attach to extend its coverage
- Link to v2: https://lore.kernel.org/r/20240910-convert_xdp_tests-v2-1-a46367c9d038@bootlin.com

Changes in v2:
- fix endianness management in userspace packet parsing (call htonl on
  constant rather than packet part)

The new test has been run in a local x86 environment and in CI:
 #560/1   xdp_cpumap_attach/CPUMAP with programs in entries:OK
 #560/2   xdp_cpumap_attach/CPUMAP with frags programs in entries:OK
 #560/3   xdp_cpumap_attach/CPUMAP attach with programs in entries on veth:OK
 #560     xdp_cpumap_attach:OK
 Summary: 1/3 PASSED, 0 SKIPPED, 0 FAILED

---
Alexis Lothoré (eBPF Foundation) (3):
      selftests/bpf: fix bpf_map_redirect call for cpu map test
      selftests/bpf: make xdp_cpumap_attach keep redirect prog attached
      selftests/bpf: check program redirect in xdp_cpumap_attach

 .../selftests/bpf/prog_tests/xdp_cpumap_attach.c   | 130 +++++++++++++++++++--
 .../bpf/progs/test_xdp_with_cpumap_helpers.c       |   7 +-
 2 files changed, 129 insertions(+), 8 deletions(-)
---
base-commit: 058d7c3d1691e2e4a4963716ec6c047dff778637
change-id: 20240730-convert_xdp_tests-ccd66bfe33db

Best regards,

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 11, 2024, 1:10 a.m. UTC | #1
Hello:

This series was applied to bpf/bpf-next.git (net)
by Martin KaFai Lau <martin.lau@kernel.org>:

On Wed, 09 Oct 2024 12:12:06 +0200 you wrote:
> Hello,
> this small series aims to increase coverage of xdp features in
> test_progs. The initial versions proposed to rework test_xdp_features.sh
> to make it fit in test_progs, but some discussions in v1 and v2 showed
> that the script is still needed as a standalone tool. So this new
> revision lets test_xdp_features.sh as-is, and rather adds missing
> coverage in existing test (cpu map). The new revision is now also a
> follow-up to the update performed by Florian Kauer in [1] for devmap
> programs testing.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v3,1/3] selftests/bpf: fix bpf_map_redirect call for cpu map test
    https://git.kernel.org/bpf/bpf-next/c/ac8d16b2d377
  - [bpf-next,v3,2/3] selftests/bpf: make xdp_cpumap_attach keep redirect prog attached
    https://git.kernel.org/bpf/bpf-next/c/d5fbcf46ee82
  - [bpf-next,v3,3/3] selftests/bpf: check program redirect in xdp_cpumap_attach
    https://git.kernel.org/bpf/bpf-next/c/d124d984c8a2

You are awesome, thank you!