| Message ID | cover.1589835155.git.sai.praneeth.prakhya@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Miscellaneous fixes for resctrl selftests | expand |
Hi Sai, On 5/18/2020 3:08 PM, Sai Praneeth Prakhya wrote: > Fenghua Yu (1): > selftests/resctrl: Fix missing options "-n" and "-p" > > Reinette Chatre (3): > selftests/resctrl: Fix typo > selftests/resctrl: Fix typo in help text > selftests/resctrl: Ensure sibling CPU is not same as original CPU > > Sai Praneeth Prakhya (15): > selftests/resctrl: Rename CQM test as CMT test > selftests/resctrl: Declare global variables as extern > selftests/resctrl: Return if resctrl file system is not supported > selftests/resctrl: Check for resctrl mount point only if resctrl FS is > supported > selftests/resctrl: Use resctrl/info for feature detection > selftests/resctrl: Fix MBA/MBM results reporting format > selftests/resctrl: Abort running tests if not root user > selftests/resctrl: Enable gcc checks to detect buffer overflows > selftests/resctrl: Dynamically select buffer size for CAT test > selftests/resctrl: Skip the test if requested resctrl feature is not > supported > selftests/resctrl: Change return type of umount_resctrlfs() to void > selftests/resctrl: Umount resctrl FS only if mounted > selftests/resctrl: Unmount resctrl FS after running all tests > selftests/resctrl: Fix incorrect parsing of iMC counters > selftests/resctrl: Fix checking for < 0 for unsigned values > > tools/testing/selftests/resctrl/Makefile | 2 +- > tools/testing/selftests/resctrl/README | 4 +- > tools/testing/selftests/resctrl/cache.c | 4 +- > tools/testing/selftests/resctrl/cat_test.c | 8 +- > .../resctrl/{cqm_test.c => cmt_test.c} | 23 +++--- > tools/testing/selftests/resctrl/mba_test.c | 23 +++--- > tools/testing/selftests/resctrl/mbm_test.c | 16 ++-- > tools/testing/selftests/resctrl/resctrl.h | 20 +++-- > .../testing/selftests/resctrl/resctrl_tests.c | 69 ++++++++++++----- > tools/testing/selftests/resctrl/resctrl_val.c | 67 ++++++++++------ > tools/testing/selftests/resctrl/resctrlfs.c | 77 +++++++++++++------ > 11 files changed, 195 insertions(+), 118 deletions(-) > rename tools/testing/selftests/resctrl/{cqm_test.c => cmt_test.c} (88%) > Thank you very much for creating these fixes. There are a few to which I responded directly, the rest look good to me. Reinette
Hi Reinette, > -----Original Message----- > From: Reinette Chatre <reinette.chatre@intel.com> > Sent: Thursday, May 21, 2020 9:12 AM > To: Prakhya, Sai Praneeth <sai.praneeth.prakhya@intel.com>; > shuah@kernel.org; skhan@linuxfoundation.org; linux-kselftest@vger.kernel.org > Cc: tglx@linutronix.de; mingo@redhat.com; bp@alien8.de; Luck, Tony > <tony.luck@intel.com>; babu.moger@amd.com; james.morse@arm.com; > Shankar, Ravi V <ravi.v.shankar@intel.com>; Yu, Fenghua > <fenghua.yu@intel.com>; x86@kernel.org; LKML <linux- > kernel@vger.kernel.org>; dan.carpenter@oracle.com; dcb314@hotmail.com > Subject: Re: [PATCH V2 00/19] Miscellaneous fixes for resctrl selftests > > Hi Sai, > > On 5/18/2020 3:08 PM, Sai Praneeth Prakhya wrote: > > Fenghua Yu (1): > > selftests/resctrl: Fix missing options "-n" and "-p" [SNIP] > Thank you very much for creating these fixes. There are a few to which I > responded directly, the rest look good to me. Thanks a lot! for reviewing the patches. I will post a V3 addressing your comments. Regards, Sai
This patch set has several miscellaneous fixes to resctrl selftest tool that are easily visible to user. V1 had fixes to CAT test and CMT test but they were dropped in V2 because having them here made the patchset humongous. So, changes to CAT test and CMT test will be posted in another patchset. Some warnings reported by sparse tool were fixed in this patchset but some are not yet fixed. They will be fixed in another patchset. Patches 1 to 14, 18 and 19 are independent fixes. Patches 15 and 16 are preparatory patches for patch 17. Thanks to Dan and David for reporting couple of issues. V1 can be found at: https://lkml.org/lkml/2020/3/6/1249 Based on v5.7-rc6. Changes from V1: ================ 1. Dropped changes to CAT test and CMT test as they will be posted in a later series. 2. Added several other fixes Fenghua Yu (1): selftests/resctrl: Fix missing options "-n" and "-p" Reinette Chatre (3): selftests/resctrl: Fix typo selftests/resctrl: Fix typo in help text selftests/resctrl: Ensure sibling CPU is not same as original CPU Sai Praneeth Prakhya (15): selftests/resctrl: Rename CQM test as CMT test selftests/resctrl: Declare global variables as extern selftests/resctrl: Return if resctrl file system is not supported selftests/resctrl: Check for resctrl mount point only if resctrl FS is supported selftests/resctrl: Use resctrl/info for feature detection selftests/resctrl: Fix MBA/MBM results reporting format selftests/resctrl: Abort running tests if not root user selftests/resctrl: Enable gcc checks to detect buffer overflows selftests/resctrl: Dynamically select buffer size for CAT test selftests/resctrl: Skip the test if requested resctrl feature is not supported selftests/resctrl: Change return type of umount_resctrlfs() to void selftests/resctrl: Umount resctrl FS only if mounted selftests/resctrl: Unmount resctrl FS after running all tests selftests/resctrl: Fix incorrect parsing of iMC counters selftests/resctrl: Fix checking for < 0 for unsigned values tools/testing/selftests/resctrl/Makefile | 2 +- tools/testing/selftests/resctrl/README | 4 +- tools/testing/selftests/resctrl/cache.c | 4 +- tools/testing/selftests/resctrl/cat_test.c | 8 +- .../resctrl/{cqm_test.c => cmt_test.c} | 23 +++--- tools/testing/selftests/resctrl/mba_test.c | 23 +++--- tools/testing/selftests/resctrl/mbm_test.c | 16 ++-- tools/testing/selftests/resctrl/resctrl.h | 20 +++-- .../testing/selftests/resctrl/resctrl_tests.c | 69 ++++++++++++----- tools/testing/selftests/resctrl/resctrl_val.c | 67 ++++++++++------ tools/testing/selftests/resctrl/resctrlfs.c | 77 +++++++++++++------ 11 files changed, 195 insertions(+), 118 deletions(-) rename tools/testing/selftests/resctrl/{cqm_test.c => cmt_test.c} (88%)