| Message ID | cover.1688078604.git.falcon@tinylab.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | allow run with minimal kernel config | expand |
On 2023-06-30 07:22:39+0800, Zhangjin Wu wrote: > Willy, Thomas > > This is v2 to allow run with minimal kernel config, see v1 [1]. > > It mainly applied the suggestions from Thomas. It is based on our > previous v5 sysret helper series [2] and Thomas' chmod_net removal > patchset [3]. > > Now, a test report on arm/vexpress-a9 without procfs, shmem, tmpfs, net > and memfd_create looks like: > > LOG: testing report for arm/vexpress-a9: > > 14 chmod_net [SKIPPED] Shouldn't this be gone? > 15 chmod_self [SKIPPED] > 17 chown_self [SKIPPED] > 41 link_cross [SKIPPED] > 0 -fstackprotector not supported [SKIPPED] > > 139 test(s) passed, 5 skipped, 0 failed. > See all results in /labs/linux-lab/logging/nolibc/arm-vexpress-a9-nolibc-test.log > > LOG: testing summary: > > arch/board | result > ------------|------------ > arm/vexpress-a9 | 139 test(s) passed, 5 skipped, 0 failed. See all results in /labs/linux-lab/logging/nolibc/arm-vexpress-a9-nolibc-test.log > [..] > tools/include/nolibc/sys.h | 22 ++++ > tools/testing/selftests/nolibc/nolibc-test.c | 102 +++++++++++++++---- > 2 files changed, 106 insertions(+), 18 deletions(-) A few nitpicks left, mentioned on the patches themselves. In general: for the full series. Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>
Hi, Thomas > On 2023-06-30 07:22:39+0800, Zhangjin Wu wrote: > > Willy, Thomas > > > > This is v2 to allow run with minimal kernel config, see v1 [1]. > > > > It mainly applied the suggestions from Thomas. It is based on our > > previous v5 sysret helper series [2] and Thomas' chmod_net removal > > patchset [3]. > > > > Now, a test report on arm/vexpress-a9 without procfs, shmem, tmpfs, net > > and memfd_create looks like: > > > > LOG: testing report for arm/vexpress-a9: > > > > 14 chmod_net [SKIPPED] > > Shouldn't this be gone? > Yes, if apply your chmod_net removal patches before this series: LOG: testing report for arm/vexpress-a9: 14 chmod_self [SKIPPED] 16 chown_self [SKIPPED] 40 link_cross [SKIPPED] 0 -fstackprotector not supported [SKIPPED] 139 test(s) passed, 4 skipped, 0 failed. See all results in /labs/linux-lab/logging/nolibc/arm-vexpress-a9-nolibc-test.log LOG: testing summary: arch/board | result ------------|------------ arm/vexpress-a9 | 139 test(s) passed, 4 skipped, 0 failed. See all results in /labs/linux-lab/logging/nolibc/arm-vexpress-a9-nolibc-test.log This test also applied the new proposed chroot_exe and chmod_tmpfile from https://lore.kernel.org/lkml/20230630111433.211130-1-falcon@tinylab.org/ > > 15 chmod_self [SKIPPED] > > 17 chown_self [SKIPPED] > > 41 link_cross [SKIPPED] > > 0 -fstackprotector not supported [SKIPPED] > > > > 139 test(s) passed, 5 skipped, 0 failed. > > See all results in /labs/linux-lab/logging/nolibc/arm-vexpress-a9-nolibc-test.log > > > > LOG: testing summary: > > > > arch/board | result > > ------------|------------ > > arm/vexpress-a9 | 139 test(s) passed, 5 skipped, 0 failed. See all results in /labs/linux-lab/logging/nolibc/arm-vexpress-a9-nolibc-test.log > > > [..] > > > tools/include/nolibc/sys.h | 22 ++++ > > tools/testing/selftests/nolibc/nolibc-test.c | 102 +++++++++++++++---- > > 2 files changed, 106 insertions(+), 18 deletions(-) > > A few nitpicks left, mentioned on the patches themselves. > > In general: for the full series. > > Reviewed-by: Thomas Weißschuh <linux@weissschuh.net> > Thanks Thomas, will send v3 later. Best regards, Zhangjin
Willy, Thomas This is v2 to allow run with minimal kernel config, see v1 [1]. It mainly applied the suggestions from Thomas. It is based on our previous v5 sysret helper series [2] and Thomas' chmod_net removal patchset [3]. Now, a test report on arm/vexpress-a9 without procfs, shmem, tmpfs, net and memfd_create looks like: LOG: testing report for arm/vexpress-a9: 14 chmod_net [SKIPPED] 15 chmod_self [SKIPPED] 17 chown_self [SKIPPED] 41 link_cross [SKIPPED] 0 -fstackprotector not supported [SKIPPED] 139 test(s) passed, 5 skipped, 0 failed. See all results in /labs/linux-lab/logging/nolibc/arm-vexpress-a9-nolibc-test.log LOG: testing summary: arch/board | result ------------|------------ arm/vexpress-a9 | 139 test(s) passed, 5 skipped, 0 failed. See all results in /labs/linux-lab/logging/nolibc/arm-vexpress-a9-nolibc-test.log Changes from v1 --> v2: * selftests/nolibc: stat_fault: silence NULL argument warning with glibc selftests/nolibc: gettid: restore for glibc and musl selftests/nolibc: add _LARGEFILE64_SOURCE for musl selftests/nolibc: add a new rmdir() test case selftests/nolibc: fix up failures when CONFIG_PROC_FS=n The same as v1, only a few of commit message changes. * selftests/nolibc: fix up int_fast16/32_t test cases for musl Applied the method suggested by Thomas, two new macros are added to get SINT_MAX_OF_TYPE(type) and SINT_MIN_OF_TYPE(type). * selftests/nolibc: fix up kernel parameters support After discuss with Thomas and with more tests, both of argv[1] and NOLIBC_TEST environment variable should be verified to support such kernel parameters: NOLIBC_TEST=syscall noapic NOLIBC_TEST=syscall noapic * selftests/nolibc: stat_timestamps: remove procfs dependency Add '/init' and '/' for !procfs, don't skip it. * selftests/nolibc: link_cross: use /proc/self/cmdline Use /proc/self/cmdline instead of /proc/self/net, the ramfs based /tmp/file doesn't work as expected (not really crossdev). * tools/nolibc: add rmdir() support Now, rebased on __sysret() from sysret helper patchset [2]. * selftests/nolibc: prepare /tmp for tmpfs or ramfs Removed the hugetlbfs prepare part, not really required. Don't remove /tmp and reserve it to use ramfs as tmpfs. * selftests/nolibc: add common get_tmpfile() selftests/nolibc: rename chroot_exe to chroot_tmpfile Some cleanups. * selftests/nolibc: add chmod_tmpfile test To avoid conflict with Thomas' chmod_net removal patch [3], a new chmod_tmpfile is added (in v1, there is a rename patch from chmod_net to chmod_good) Still to avoid conflict, these two are removed in this series: - selftests/nolibc: rename proc variable to has_proc - selftests/nolibc: rename euid0 variable to is_root * selftests/nolibc: vfprintf: remove MEMFD_CREATE dependency Many checks are removed, only reserve the direct tmpfs access version. Best regards, Zhangjin --- [1]: https://lore.kernel.org/lkml/cover.1687344643.git.falcon@tinylab.org/ [2]: https://lore.kernel.org/lkml/cover.1687976753.git.falcon@tinylab.org/ [3]: https://lore.kernel.org/lkml/20230624-proc-net-setattr-v1-0-73176812adee@weissschuh.net/ Zhangjin Wu (15): selftests/nolibc: stat_fault: silence NULL argument warning with glibc selftests/nolibc: gettid: restore for glibc and musl selftests/nolibc: add _LARGEFILE64_SOURCE for musl selftests/nolibc: fix up int_fast16/32_t test cases for musl selftests/nolibc: fix up kernel parameters support selftests/nolibc: stat_timestamps: remove procfs dependency selftests/nolibc: link_cross: use /proc/self/cmdline tools/nolibc: add rmdir() support selftests/nolibc: add a new rmdir() test case selftests/nolibc: fix up failures when CONFIG_PROC_FS=n selftests/nolibc: prepare /tmp for tmpfs or ramfs selftests/nolibc: add common get_tmpfile() selftests/nolibc: rename chroot_exe to chroot_tmpfile selftests/nolibc: add chmod_tmpfile test selftests/nolibc: vfprintf: remove MEMFD_CREATE dependency tools/include/nolibc/sys.h | 22 ++++ tools/testing/selftests/nolibc/nolibc-test.c | 102 +++++++++++++++---- 2 files changed, 106 insertions(+), 18 deletions(-)