mbox series

[v2,0/4] add tests to verify IFS (In Field Scan) driver functionality

Message ID cover.1717137348.git.pengfei.xu@intel.com (mailing list archive)
Headers show
Series add tests to verify IFS (In Field Scan) driver functionality | expand

Message

Pengfei Xu May 31, 2024, 7:53 a.m. UTC
To verify IFS (In Field Scan [1]) driver functionality, add the following 6
test cases:
  1. Verify that IFS sysfs entries are created after loading the IFS module
  2. Check if loading an invalid IFS test image fails and loading a valid
     one succeeds
  3. Perform IFS scan test on each CPU using all the available image files
  4. Perform IFS scan with first test image file on a random CPU for 3
     rounds
  5. Perform IFS ARRAY BIST(Board Integrated System Test) test on each CPU
  6. Perform IFS ARRAY BIST test on a random CPU for 3 rounds

These are not exhaustive, but some minimal test runs to check various
parts of the driver. Some negative tests are also included.

[1] https://docs.kernel.org/arch/x86/ifs.html

Pengfei Xu (4):
  selftests: ifs: verify test interfaces are created by the driver
  selftests: ifs: verify test image loading functionality
  selftests: ifs: verify IFS scan test functionality
  selftests: ifs: verify IFS ARRAY BIST functionality

 MAINTAINERS                                   |   1 +
 tools/testing/selftests/Makefile              |   1 +
 .../drivers/platform/x86/intel/ifs/Makefile   |   6 +
 .../platform/x86/intel/ifs/test_ifs.sh        | 494 ++++++++++++++++++
 4 files changed, 502 insertions(+)
 create mode 100644 tools/testing/selftests/drivers/platform/x86/intel/ifs/Makefile
 create mode 100755 tools/testing/selftests/drivers/platform/x86/intel/ifs/test_ifs.sh

---
Changes:
v1 to v2:
  - Rebase to v6.10 cycle kernel and resolve some code conflicts
  - Improved checking of IFS ARRAY_BIST support by leveraging sysfs entry
    methods (suggested by Ashok)

Comments

Pengfei Xu June 19, 2024, 12:53 a.m. UTC | #1
On 2024-05-31 at 15:53:46 +0800, Pengfei Xu wrote:
> To verify IFS (In Field Scan [1]) driver functionality, add the following 6
> test cases:
>   1. Verify that IFS sysfs entries are created after loading the IFS module
>   2. Check if loading an invalid IFS test image fails and loading a valid
>      one succeeds
>   3. Perform IFS scan test on each CPU using all the available image files
>   4. Perform IFS scan with first test image file on a random CPU for 3
>      rounds
>   5. Perform IFS ARRAY BIST(Board Integrated System Test) test on each CPU
>   6. Perform IFS ARRAY BIST test on a random CPU for 3 rounds
> 
> These are not exhaustive, but some minimal test runs to check various
> parts of the driver. Some negative tests are also included.
> 
> [1] https://docs.kernel.org/arch/x86/ifs.html
> 
> Pengfei Xu (4):
>   selftests: ifs: verify test interfaces are created by the driver
>   selftests: ifs: verify test image loading functionality
>   selftests: ifs: verify IFS scan test functionality
>   selftests: ifs: verify IFS ARRAY BIST functionality
> 
>  MAINTAINERS                                   |   1 +
>  tools/testing/selftests/Makefile              |   1 +
>  .../drivers/platform/x86/intel/ifs/Makefile   |   6 +
>  .../platform/x86/intel/ifs/test_ifs.sh        | 494 ++++++++++++++++++
>  4 files changed, 502 insertions(+)
>  create mode 100644 tools/testing/selftests/drivers/platform/x86/intel/ifs/Makefile
>  create mode 100755 tools/testing/selftests/drivers/platform/x86/intel/ifs/test_ifs.sh
> 
> ---
> Changes:
> v1 to v2:
>   - Rebase to v6.10 cycle kernel and resolve some code conflicts
>   - Improved checking of IFS ARRAY_BIST support by leveraging sysfs entry
>     methods (suggested by Ashok)
> 

A gentle ping on this patch :)

Best Regards,
Thanks!

> -- 
> 2.43.0
>
Joseph, Jithu July 11, 2024, 1:42 a.m. UTC | #2
On 5/31/2024 1:23 PM, Pengfei Xu wrote:
> To verify IFS (In Field Scan [1]) driver functionality, add the following 6
> test cases:
>   1. Verify that IFS sysfs entries are created after loading the IFS module
>   2. Check if loading an invalid IFS test image fails and loading a valid
>      one succeeds
>   3. Perform IFS scan test on each CPU using all the available image files
>   4. Perform IFS scan with first test image file on a random CPU for 3
>      rounds
>   5. Perform IFS ARRAY BIST(Board Integrated System Test) test on each CPU
>   6. Perform IFS ARRAY BIST test on a random CPU for 3 rounds
> 
> These are not exhaustive, but some minimal test runs to check various
> parts of the driver. Some negative tests are also included.
> 
> [1] https://docs.kernel.org/arch/x86/ifs.html
> 
> Pengfei Xu (4):
>   selftests: ifs: verify test interfaces are created by the driver
>   selftests: ifs: verify test image loading functionality
>   selftests: ifs: verify IFS scan test functionality
>   selftests: ifs: verify IFS ARRAY BIST functionality
> 
>  MAINTAINERS                                   |   1 +
>  tools/testing/selftests/Makefile              |   1 +
>  .../drivers/platform/x86/intel/ifs/Makefile   |   6 +
>  .../platform/x86/intel/ifs/test_ifs.sh        | 494 ++++++++++++++++++
>  4 files changed, 502 insertions(+)
>  create mode 100644 tools/testing/selftests/drivers/platform/x86/intel/ifs/Makefile
>  create mode 100755 tools/testing/selftests/drivers/platform/x86/intel/ifs/test_ifs.sh
> 
> ---
> Changes:
> v1 to v2:
>   - Rebase to v6.10 cycle kernel and resolve some code conflicts
>   - Improved checking of IFS ARRAY_BIST support by leveraging sysfs entry
>     methods (suggested by Ashok)

For All 4 patches in this series

Acked-by: Jithu Joseph <jithu.joseph@intel.com>


Thanks
Jithu
Shuah Khan July 11, 2024, 7:30 p.m. UTC | #3
On 7/10/24 19:42, Joseph, Jithu wrote:
> Acked-by: Jithu Joseph<jithu.joseph@intel.com>

Applied to linux-kselftest next for Linux 6.11-rc1.

thanks,
-- Shuah