[mptcp-next,v3,0/6] use network helpers, part 7

Message

Geliang Tang June 17, 2024, 8:33 a.m. UTC

From: Geliang Tang <[e-mail]>

v3:
 - rename start_client to client_socket
 - Use connect_to_addr in connect_to_fd_opt

v2:
 - update patch 2, extract a new helper start_client.
 - drop patch 3, keep must_fail in network_helper_opts.

Drop type and noconnect from network_helper_opts. And use start_server_str
in mptcp and test_tcp_check_syncookie_user.

Patches 1-4 address Martin's comments in the previous series.

Geliang Tang (6):
  selftests/bpf: Drop type from network_helper_opts
  selftests/bpf: Use connect_to_addr in connect_to_fd_opt
  selftests/bpf: Add client_socket helper
  selftests/bpf: Drop noconnect from network_helper_opts
  selftests/bpf: Use start_server_str in mptcp
  selftests/bpf: Use start_server_str in test_tcp_check_syncookie_user

 tools/testing/selftests/bpf/network_helpers.c | 100 ++++++++----------
 tools/testing/selftests/bpf/network_helpers.h |   6 +-
 .../selftests/bpf/prog_tests/bpf_tcp_ca.c     |   2 +-
 .../selftests/bpf/prog_tests/cgroup_v1v2.c    |   4 +-
 .../bpf/prog_tests/ip_check_defrag.c          |  10 +-
 .../testing/selftests/bpf/prog_tests/mptcp.c  |   7 +-
 .../bpf/test_tcp_check_syncookie_user.c       |  29 +----
 7 files changed, 56 insertions(+), 102 deletions(-)

Comments

Geliang Tang June 17, 2024, 9:17 a.m. UTC | #1

Sorry, v3 breaks the CI.
Changes Requested.

-Geliang

On Mon, 2024-06-17 at 16:33 +0800, Geliang Tang wrote:
> From: Geliang Tang <[e-mail]>
> 
> v3:
>  - rename start_client to client_socket
>  - Use connect_to_addr in connect_to_fd_opt
> 
> v2:
>  - update patch 2, extract a new helper start_client.
>  - drop patch 3, keep must_fail in network_helper_opts.
> 
> Drop type and noconnect from network_helper_opts. And use
> start_server_str
> in mptcp and test_tcp_check_syncookie_user.
> 
> Patches 1-4 address Martin's comments in the previous series.
> 
> Geliang Tang (6):
>   selftests/bpf: Drop type from network_helper_opts
>   selftests/bpf: Use connect_to_addr in connect_to_fd_opt
>   selftests/bpf: Add client_socket helper
>   selftests/bpf: Drop noconnect from network_helper_opts
>   selftests/bpf: Use start_server_str in mptcp
>   selftests/bpf: Use start_server_str in
> test_tcp_check_syncookie_user
> 
>  tools/testing/selftests/bpf/network_helpers.c | 100 ++++++++--------
> --
>  tools/testing/selftests/bpf/network_helpers.h |   6 +-
>  .../selftests/bpf/prog_tests/bpf_tcp_ca.c     |   2 +-
>  .../selftests/bpf/prog_tests/cgroup_v1v2.c    |   4 +-
>  .../bpf/prog_tests/ip_check_defrag.c          |  10 +-
>  .../testing/selftests/bpf/prog_tests/mptcp.c  |   7 +-
>  .../bpf/test_tcp_check_syncookie_user.c       |  29 +----
>  7 files changed, 56 insertions(+), 102 deletions(-)
>