mbox series

[bpf-next,v11,0/9] use network helpers, part 8

Message ID cover.1720515893.git.tanggeliang@kylinos.cn (mailing list archive)
Headers show
Series use network helpers, part 8 | expand

Message

Geliang Tang July 9, 2024, 9:16 a.m. UTC
From: Geliang Tang <tanggeliang@kylinos.cn>

v11:
 - new patches 2, 4, 6.
 - drop expect_errno from network_helper_opts as Eduard and Martin
   suggested.
 - drop sockmap_ktls patches from this set.
 - add a new helper connect_fd_to_addr_str.

v10:
 - a new patch 10 is added.
 - patches 1-6, 8-9 unchanged, only commit logs updated.
 - "err = -errno" is used in patches 7, 11, 12 to get the real error
   number before checking value of "err".

v9:
 - new patches 5-7, new struct member expect_errno for network_helper_opts.
 - patches 1-4, 8-9 unchanged.
 - update patches 10-11 to make sure all tests pass.

v8:
 - only patch 8 updated, to fix errors reported by CI.

v7:
 - address Martin's comments in v6. (thanks)
 - use MAX(opts->backlog, 0) instead of opts->backlog.
 - use connect_to_fd_opts instead connect_to_fd.
 - more ASSERT_* to check errors.

v6:
 - update patch 6 as Daniel suggested. (thanks)

v5:
 - keep make_server and make_client as Eduard suggested.

v4:
 - a new patch to use make_sockaddr in sockmap_ktls.
 - a new patch to close fd in error path in drop_on_reuseport.
 - drop make_server() in patch 7.
 - drop make_client() too in patch 9.

v3:
 - a new patch to add backlog for network_helper_opts.
 - use start_server_str in sockmap_ktls now, not start_server.

v2:
 - address Eduard's comments in v1. (thanks)
 - fix errors reported by CI.

This patch set uses network helpers in sk_lookup, and drop the local
helpers inetaddr_len() and make_socket().

Geliang Tang (9):
  selftests/bpf: Add backlog for network_helper_opts
  selftests/bpf: Add ASSERT_OK_FD macro
  selftests/bpf: Close fd in error path in drop_on_reuseport
  selftests/bpf: Use start_server_str in sk_lookup
  selftests/bpf: Use start_server_addr in sk_lookup
  selftests/bpf: Use connect_fd_to_fd in sk_lookup
  selftests/bpf: Add connect_fd_to_addr_str helper
  selftests/bpf: Use connect_fd_to_addr_str in sk_lookup
  selftests/bpf: Drop make_socket in sk_lookup

 tools/testing/selftests/bpf/network_helpers.c |  23 ++-
 tools/testing/selftests/bpf/network_helpers.h |   7 +
 .../selftests/bpf/prog_tests/sk_lookup.c      | 156 ++++++------------
 tools/testing/selftests/bpf/test_progs.h      |   8 +
 4 files changed, 92 insertions(+), 102 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org July 10, 2024, 7 p.m. UTC | #1
Hello:

This series was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:

On Tue,  9 Jul 2024 17:16:16 +0800 you wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v11:
>  - new patches 2, 4, 6.
>  - drop expect_errno from network_helper_opts as Eduard and Martin
>    suggested.
>  - drop sockmap_ktls patches from this set.
>  - add a new helper connect_fd_to_addr_str.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v11,1/9] selftests/bpf: Add backlog for network_helper_opts
    https://git.kernel.org/bpf/bpf-next/c/a3016a27cea8
  - [bpf-next,v11,2/9] selftests/bpf: Add ASSERT_OK_FD macro
    https://git.kernel.org/bpf/bpf-next/c/7046345d48ad
  - [bpf-next,v11,3/9] selftests/bpf: Close fd in error path in drop_on_reuseport
    https://git.kernel.org/bpf/bpf-next/c/adae187ebedc
  - [bpf-next,v11,4/9] selftests/bpf: Use start_server_str in sk_lookup
    https://git.kernel.org/bpf/bpf-next/c/14fc6fcd35e7
  - [bpf-next,v11,5/9] selftests/bpf: Use start_server_addr in sk_lookup
    https://git.kernel.org/bpf/bpf-next/c/d9810c43f660
  - [bpf-next,v11,6/9] selftests/bpf: Use connect_fd_to_fd in sk_lookup
    https://git.kernel.org/bpf/bpf-next/c/9004054b1629
  - [bpf-next,v11,7/9] selftests/bpf: Add connect_fd_to_addr_str helper
    (no matching commit)
  - [bpf-next,v11,8/9] selftests/bpf: Use connect_fd_to_addr_str in sk_lookup
    (no matching commit)
  - [bpf-next,v11,9/9] selftests/bpf: Drop make_socket in sk_lookup
    (no matching commit)

You are awesome, thank you!