| Message ID | 0baf91dc24b95ae0cadfdf5db05b74888e6a228a.1724430120.git.petrm@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e8497d6951ee8541d73784f9aac9942a7f239980 |
| Headers | show |
| Series | [net-next] selftests: forwarding: no_forwarding: Down ports on cleanup | expand |
On Fri, Aug 23, 2024 at 06:25:37PM +0200, Petr Machata wrote: > This test neglects to put ports down on cleanup. Fix it. > > Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test") > Signed-off-by: Petr Machata <petrm@nvidia.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 23 Aug 2024 18:25:37 +0200 you wrote: > This test neglects to put ports down on cleanup. Fix it. > > Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test") > Signed-off-by: Petr Machata <petrm@nvidia.com> > --- > tools/testing/selftests/net/forwarding/no_forwarding.sh | 3 +++ > 1 file changed, 3 insertions(+) Here is the summary with links: - [net-next] selftests: forwarding: no_forwarding: Down ports on cleanup https://git.kernel.org/netdev/net/c/e8497d6951ee You are awesome, thank you!
diff --git a/tools/testing/selftests/net/forwarding/no_forwarding.sh b/tools/testing/selftests/net/forwarding/no_forwarding.sh index af3b398d13f0..9e677aa64a06 100755 --- a/tools/testing/selftests/net/forwarding/no_forwarding.sh +++ b/tools/testing/selftests/net/forwarding/no_forwarding.sh @@ -233,6 +233,9 @@ cleanup() { pre_cleanup + ip link set dev $swp2 down + ip link set dev $swp1 down + h2_destroy h1_destroy
This test neglects to put ports down on cleanup. Fix it. Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test") Signed-off-by: Petr Machata <petrm@nvidia.com> --- tools/testing/selftests/net/forwarding/no_forwarding.sh | 3 +++ 1 file changed, 3 insertions(+)