| Message ID | 1663850569-33122-1-git-send-email-wangyufen@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bc7a319844891746135dc1f34ab9df78d636a3ac |
| Headers | show |
| Series | [net-next] selftests: Fix the if conditions of in test_extra_filter() | expand |
On Thu, 22 Sep 2022 20:42:49 +0800 Wang Yufen wrote: > The socket 2 bind the addr in use, bind should fail with EADDRINUSE. So > if bind success or errno != EADDRINUSE, testcase should be failed. Please add a Fixes tag, even if the buggy commit has not reached Linus yet.
在 2022/9/22 21:12, Jakub Kicinski 写道: > On Thu, 22 Sep 2022 20:42:49 +0800 Wang Yufen wrote: >> The socket 2 bind the addr in use, bind should fail with EADDRINUSE. So >> if bind success or errno != EADDRINUSE, testcase should be failed. > Please add a Fixes tag, even if the buggy commit has not reached Linus > yet. Thanks for your comment. will add in v2
diff --git a/tools/testing/selftests/net/reuseport_bpf.c b/tools/testing/selftests/net/reuseport_bpf.c index 072d709c..65aea27 100644 --- a/tools/testing/selftests/net/reuseport_bpf.c +++ b/tools/testing/selftests/net/reuseport_bpf.c @@ -328,7 +328,7 @@ static void test_extra_filter(const struct test_params p) if (bind(fd1, addr, sockaddr_size())) error(1, errno, "failed to bind recv socket 1"); - if (!bind(fd2, addr, sockaddr_size()) && errno != EADDRINUSE) + if (!bind(fd2, addr, sockaddr_size()) || errno != EADDRINUSE) error(1, errno, "bind socket 2 should fail with EADDRINUSE"); free(addr);
The socket 2 bind the addr in use, bind should fail with EADDRINUSE. So if bind success or errno != EADDRINUSE, testcase should be failed. Signed-off-by: Wang Yufen <wangyufen@huawei.com> --- tools/testing/selftests/net/reuseport_bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)