diff mbox series

[net-next,03/12] selftests: lib: tc_rule_stats_get(): Move default to argument definition

Message ID 18d1da8cf474d76e7934d06c546a22e6561392b3.1719497773.git.petrm@nvidia.com (mailing list archive)
State Accepted
Commit 9b5d5f272654ca4b97f39b6ef809e4edef794fdc
Headers show
Series selftest: Clean-up and stabilize mirroring tests | expand

Commit Message

Petr Machata June 27, 2024, 2:48 p.m. UTC 
The argument $dir has a fallback value of "ingress". Move the fallback from
the usage site to the argument definition block to make the fact clearer.

Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Danielle Ratson <danieller@nvidia.com>
---
 tools/testing/selftests/net/lib.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/lib.sh b/tools/testing/selftests/net/lib.sh
index 915f319bcc8b..d0219032f773 100644
--- a/tools/testing/selftests/net/lib.sh
+++ b/tools/testing/selftests/net/lib.sh
@@ -199,10 +199,10 @@  tc_rule_stats_get()
 {
 	local dev=$1; shift
 	local pref=$1; shift
-	local dir=$1; shift
+	local dir=${1:-ingress}; shift
 	local selector=${1:-.packets}; shift
 
-	tc -j -s filter show dev $dev ${dir:-ingress} pref $pref \
+	tc -j -s filter show dev $dev $dir pref $pref \
 	    | jq ".[1].options.actions[].stats$selector"
 }