| Message ID | 20180530220339.6107-1-ahiliation@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 05/30/2018 04:03 PM, Jeffrin Jose T wrote: > The intel_pstate related testing script need root level privileges > when trying to access certain file for the successful execution of > the script.But this is not the case always like when using evaluation > only mode, which only require user level privilege. > > This patch is to notify the user about the privilege the script > demands for the successful execution of the test. > > Signed-off-by: Jeffrin Jose T (Rajagiri SET) <ahiliation@gmail.com> > --- I will take this patch and apply it to linux-kselftest next for 4.18-rc1. For next time, this patch should have been tagged v2 not RESEND. Also please include changes made since the last version in this spot after the Signed-off-by line. > tools/testing/selftests/intel_pstate/run.sh | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh > index 8576f6564307..e7008f614ad7 100755 > --- a/tools/testing/selftests/intel_pstate/run.sh > +++ b/tools/testing/selftests/intel_pstate/run.sh > @@ -38,6 +38,12 @@ if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then > exit $ksft_skip > fi > > +msg="skip all tests:" > +if [ $UID != 0 ] && [ $EVALUATE_ONLY == 0 ]; then > + echo $msg please run this as root >&2 > + exit $ksft_skip > +fi > + > max_cpus=$(($(nproc)-1)) > > function run_test () { > thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 31, 2018 at 5:12 AM, Shuah Khan <shuah@kernel.org> wrote: > I will take this patch and apply it to linux-kselftest next for 4.18-rc1. anyway thanks . > For next time, this patch should have been tagged v2 not RESEND. Also please > include changes made since the last version in this spot after the Signed-off-by > line. thanks for correction -- software engineer rajagiri school of engineering and technology -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh index 8576f6564307..e7008f614ad7 100755 --- a/tools/testing/selftests/intel_pstate/run.sh +++ b/tools/testing/selftests/intel_pstate/run.sh @@ -38,6 +38,12 @@ if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then exit $ksft_skip fi +msg="skip all tests:" +if [ $UID != 0 ] && [ $EVALUATE_ONLY == 0 ]; then + echo $msg please run this as root >&2 + exit $ksft_skip +fi + max_cpus=$(($(nproc)-1)) function run_test () {
The intel_pstate related testing script need root level privileges when trying to access certain file for the successful execution of the script.But this is not the case always like when using evaluation only mode, which only require user level privilege. This patch is to notify the user about the privilege the script demands for the successful execution of the test. Signed-off-by: Jeffrin Jose T (Rajagiri SET) <ahiliation@gmail.com> --- tools/testing/selftests/intel_pstate/run.sh | 6 ++++++ 1 file changed, 6 insertions(+)