| Message ID | 20180612232403.28031-1-shuah@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Thanks for the clean up, Shuah. Looks good to me. Tom On 06/12/2018 05:24 PM, Shuah Khan (Samsung OSG) wrote: > Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in > lib.mk. Common defines work just fine and there is no need to define > custom overrides. > > Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/13/2018 11:18 AM, Tom Hromatka wrote: > Thanks for the clean up, Shuah. Looks good to me. > > Tom > > > > On 06/12/2018 05:24 PM, Shuah Khan (Samsung OSG) wrote: >> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in >> lib.mk. Common defines work just fine and there is no need to define >> custom overrides. >> >> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> > > Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com> > > get_maintainers didn't include your name for this patch. Would you like to take this fix through sparc tree? This is cleanup fix would be good candidate for 4.18-rc2 If so, please let me know if you would like me to resend the patch with Tom's Reviewed-by tag. thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tools/testing/selftests/sparc64/Makefile b/tools/testing/selftests/sparc64/Makefile index 442f0ca45441..76b2206932c3 100644 --- a/tools/testing/selftests/sparc64/Makefile +++ b/tools/testing/selftests/sparc64/Makefile @@ -28,10 +28,6 @@ all: fi \ done -override define RUN_TESTS - @cd $(OUTPUT); ./run.sh -endef - override define INSTALL_RULE mkdir -p $(INSTALL_PATH) install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) @@ -43,10 +39,6 @@ override define INSTALL_RULE done; endef -override define EMIT_TESTS - echo "./run.sh" -endef - override define CLEAN @for DIR in $(SUBDIRS); do \ BUILD_TARGET=$(OUTPUT)/$$DIR; \
Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in lib.mk. Common defines work just fine and there is no need to define custom overrides. Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> --- tools/testing/selftests/sparc64/Makefile | 8 -------- 1 file changed, 8 deletions(-)