| Message ID | 20180821161212.5750-1-anders.roxell@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | selftests: net: move fragment forwarding/config up a level | expand |
On Tue, Aug 21, 2018 at 06:12:12PM +0200, Anders Roxell wrote: > 'make kselftest-merge' assumes that the config files for the tests are > located under the 'main' tet dir, like tools/testing/selftests/net/ and > not in a subdir to net. The tests under tools/testing/selftests/net/forwarding/ aren't executed as part of the Makefile. The config file is there mainly so that people will know which config options they need in order to run the tests. The tests can be added to the Makefile, but some of them take a few minutes to complete which is probably against "Don't take too long;" mentioned in Documentation/dev-tools/kselftest.rst.
On 08/21/2018 12:56 PM, Ido Schimmel wrote: > On Tue, Aug 21, 2018 at 06:12:12PM +0200, Anders Roxell wrote: >> 'make kselftest-merge' assumes that the config files for the tests are >> located under the 'main' tet dir, like tools/testing/selftests/net/ and >> not in a subdir to net. > > The tests under tools/testing/selftests/net/forwarding/ aren't executed > as part of the Makefile. The config file is there mainly so that people > will know which config options they need in order to run the tests. > > The tests can be added to the Makefile, but some of them take a few > minutes to complete which is probably against "Don't take too long;" > mentioned in Documentation/dev-tools/kselftest.rst. > I don't see any reason why these shouldn't be added. With the number of tests that get run by default, time has gone up. The goal is to run more tests not less. There are some stress/destructive tests that continue to be left out of the Makefile. thanks, -- Shuah
On Tue, Aug 21, 2018 at 01:41:54PM -0600, Shuah Khan wrote: > On 08/21/2018 12:56 PM, Ido Schimmel wrote: > > On Tue, Aug 21, 2018 at 06:12:12PM +0200, Anders Roxell wrote: > >> 'make kselftest-merge' assumes that the config files for the tests are > >> located under the 'main' tet dir, like tools/testing/selftests/net/ and > >> not in a subdir to net. > > > > The tests under tools/testing/selftests/net/forwarding/ aren't executed > > as part of the Makefile. The config file is there mainly so that people > > will know which config options they need in order to run the tests. > > > > The tests can be added to the Makefile, but some of them take a few > > minutes to complete which is probably against "Don't take too long;" > > mentioned in Documentation/dev-tools/kselftest.rst. > > > > I don't see any reason why these shouldn't be added. With the number of > tests that get run by default, time has gone up. The goal is to run more > tests not less. There are some stress/destructive tests that continue to > be left out of the Makefile. Thanks for clarifying. I'll add the tests.
On 08/22/2018 12:45 AM, Ido Schimmel wrote: > On Tue, Aug 21, 2018 at 01:41:54PM -0600, Shuah Khan wrote: >> On 08/21/2018 12:56 PM, Ido Schimmel wrote: >>> On Tue, Aug 21, 2018 at 06:12:12PM +0200, Anders Roxell wrote: >>>> 'make kselftest-merge' assumes that the config files for the tests are >>>> located under the 'main' tet dir, like tools/testing/selftests/net/ and >>>> not in a subdir to net. >>> >>> The tests under tools/testing/selftests/net/forwarding/ aren't executed >>> as part of the Makefile. The config file is there mainly so that people >>> will know which config options they need in order to run the tests. >>> >>> The tests can be added to the Makefile, but some of them take a few >>> minutes to complete which is probably against "Don't take too long;" >>> mentioned in Documentation/dev-tools/kselftest.rst. >>> >> >> I don't see any reason why these shouldn't be added. With the number of >> tests that get run by default, time has gone up. The goal is to run more >> tests not less. There are some stress/destructive tests that continue to >> be left out of the Makefile. > > Thanks for clarifying. I'll add the tests. > Great. This change to move config up one level looks good to me. Dave takes net selftest patches through net tree usually. So I will leave this up to take it through his process. Acked-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> thanks, -- Shuah
diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config index cd3a2f1545b5..b344619b34f2 100644 --- a/tools/testing/selftests/net/config +++ b/tools/testing/selftests/net/config @@ -2,15 +2,20 @@ CONFIG_USER_NS=y CONFIG_BPF_SYSCALL=y CONFIG_TEST_BPF=m CONFIG_NUMA=y -CONFIG_NET_VRF=y +CONFIG_NET_VRF=m CONFIG_NET_L3_MASTER_DEV=y CONFIG_IPV6=y CONFIG_IPV6_MULTIPLE_TABLES=y -CONFIG_VETH=y +CONFIG_VETH=m CONFIG_INET_XFRM_MODE_TUNNEL=y CONFIG_NET_IPVTI=y CONFIG_INET6_XFRM_MODE_TUNNEL=y CONFIG_IPV6_VTI=y CONFIG_DUMMY=y -CONFIG_BRIDGE=y -CONFIG_VLAN_8021Q=y +CONFIG_BRIDGE=m +CONFIG_VLAN_8021Q=m +CONFIG_CGROUP_BPF=y +CONFIG_NET_CLS_FLOWER=m +CONFIG_NET_SCH_INGRESS=m +CONFIG_NET_ACT_GACT=m +CONFIG_BRIDGE_VLAN_FILTERING=y diff --git a/tools/testing/selftests/net/forwarding/config b/tools/testing/selftests/net/forwarding/config deleted file mode 100644 index 5cd2aed97958..000000000000 --- a/tools/testing/selftests/net/forwarding/config +++ /dev/null @@ -1,12 +0,0 @@ -CONFIG_BRIDGE=m -CONFIG_VLAN_8021Q=m -CONFIG_BRIDGE_VLAN_FILTERING=y -CONFIG_NET_L3_MASTER_DEV=y -CONFIG_IPV6_MULTIPLE_TABLES=y -CONFIG_NET_VRF=m -CONFIG_BPF_SYSCALL=y -CONFIG_CGROUP_BPF=y -CONFIG_NET_CLS_FLOWER=m -CONFIG_NET_SCH_INGRESS=m -CONFIG_NET_ACT_GACT=m -CONFIG_VETH=m
'make kselftest-merge' assumes that the config files for the tests are located under the 'main' tet dir, like tools/testing/selftests/net/ and not in a subdir to net. Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- tools/testing/selftests/net/config | 13 +++++++++---- tools/testing/selftests/net/forwarding/config | 12 ------------ 2 files changed, 9 insertions(+), 16 deletions(-) delete mode 100644 tools/testing/selftests/net/forwarding/config