| Message ID | 20191016153606.2326-3-christian.brauner@ubuntu.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/5] pidfd: verify task is alive when printing fdinfo | expand |
diff --git a/kernel/pid.c b/kernel/pid.c index 0a9f2e437217..70ad4a9f728c 100644 --- a/kernel/pid.c +++ b/kernel/pid.c @@ -299,7 +299,7 @@ static void __change_pid(struct task_struct *task, enum pid_type type, *pid_ptr = new; for (tmp = PIDTYPE_MAX; --tmp >= 0; ) - if (!hlist_empty(&pid->tasks[tmp])) + if (task_alive(pid, tmp)) return; free_pid(pid);
Replace hlist_empty() with the new task_alive() helper which is more idiomatic, easier to grep for, and unifies how callers perform this check. Cc: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> --- /* v1 */ patch not present /* v2 */ patch introduced --- kernel/pid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)