From patchwork Wed Nov 4 10:07:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Ellerman X-Patchwork-Id: 11880139 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E72B314C0 for ; Wed, 4 Nov 2020 10:07:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C28882224E for ; Wed, 4 Nov 2020 10:07:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="iJ3sjZA1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728678AbgKDKHO (ORCPT ); Wed, 4 Nov 2020 05:07:14 -0500 Received: from ozlabs.org ([203.11.71.1]:35273 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727389AbgKDKHN (ORCPT ); Wed, 4 Nov 2020 05:07:13 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 4CR2Pr0TM2z9sTK; Wed, 4 Nov 2020 21:07:12 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1604484432; bh=MLycki1ORc3U1v+8blutc4vn9QHgJZyKlcel6wN5aHA=; h=From:To:Cc:Subject:Date:From; b=iJ3sjZA1RKSE4YhM7Qp8jPm5udAQqT1QItAbUZrD+F9DXYfOca1Jy2Z2rwZcyDWiK DqK56QgE44JnpDBqz+fYEcXvbWt4HM5Pypjy/TzUrTt4yWsnPGUctbvFZRKCxgWL4F rQ0exUcn6wulnlrJjamg6eK5r4XSApY5BnZOn2UMbo80cc7maJPEJAs6A2wQxlm7dp iaFgfBBIUpc/wUiox4o6A4GLBCMOdrjby91lzQks6hqb7unTRtaG1hipO2FbOlvQ1o Lx0Z3JUMV7P/epCGxmFT/1US9wQzIrUlLC/pUxuHfKZJIpKJmGNRiDEpjpz9EGdYt3 lmNsSjMt7Iw4Q== From: Michael Ellerman To: linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, keescook@chromium.org Subject: [PATCH] selftests/exec: Fix building of exec test Date: Wed, 4 Nov 2020 21:07:06 +1100 Message-Id: <20201104100706.659089-1-mpe@ellerman.id.au> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Currently the exec test does not build: make[1]: Entering directory '/linux/tools/testing/selftests/exec' ... make[1]: *** No rule to make target '/output/kselftest/exec/pipe', needed by 'all'. This is because pipe is listed in TEST_GEN_FILES, but pipe is not generated by the Makefile, it's created at runtime. So drop pipe from TEST_GEN_FILES. With that fixed, then install fails: make[1]: Entering directory '/linux/tools/testing/selftests/exec' rsync -a binfmt_script non-regular /output/install/exec/ rsync: link_stat "/linux/tools/testing/selftests/exec/non-regular" failed: No such file or directory (2) That's because non-regular hasn't been built, because it's in TEST_PROGS, it should be part of TEST_GEN_PROGS to indicate that it needs to be built. Signed-off-by: Michael Ellerman Acked-by: Kees Cook --- tools/testing/selftests/exec/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) base-commit: cf7cd542d1b538f6e9e83490bc090dd773f4266d diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile index cf69b2fcce59..a1e8a7abf576 100644 --- a/tools/testing/selftests/exec/Makefile +++ b/tools/testing/selftests/exec/Makefile @@ -3,9 +3,9 @@ CFLAGS = -Wall CFLAGS += -Wno-nonnull CFLAGS += -D_GNU_SOURCE -TEST_PROGS := binfmt_script non-regular -TEST_GEN_PROGS := execveat load_address_4096 load_address_2097152 load_address_16777216 -TEST_GEN_FILES := execveat.symlink execveat.denatured script subdir pipe +TEST_PROGS := binfmt_script +TEST_GEN_PROGS := execveat non-regular load_address_4096 load_address_2097152 load_address_16777216 +TEST_GEN_FILES := execveat.symlink execveat.denatured script subdir # Makefile is a run-time dependency, since it's accessed by the execveat test TEST_FILES := Makefile