diff mbox series

[linux-next] kselftest: remove duplicate include in cs_prctl_test.c

Message ID 20210805061919.627607-1-yong.yiran@zte.com.cn (mailing list archive)
State Accepted
Commit 3673fdeafd5f9d9aa90b35f7e11a556fe0cbbe62
Headers show
Series [linux-next] kselftest: remove duplicate include in cs_prctl_test.c | expand

Commit Message

CGEL Aug. 5, 2021, 6:19 a.m. UTC
From: yong yiran <yong.yiran@zte.com.cn>

'sys/types.h' included in 'cs_prctl_test.c' is duplicated.
Remove all but the first include of sys/types.h from cs_prctl_test.c.

'sys/wait.h' include in 'cs_prctl_test.c' is duplicated.
Remove all but the first include of sys/wait.h from cs_prctl_test.c.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: yong yiran <yong.yiran@zte.com.cn>
---
 tools/testing/selftests/sched/cs_prctl_test.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Shuah Khan Aug. 24, 2021, 2:40 p.m. UTC | #1
On 8/5/21 12:19 AM, cgel.zte@gmail.com wrote:
> From: yong yiran <yong.yiran@zte.com.cn>
> 
> 'sys/types.h' included in 'cs_prctl_test.c' is duplicated.
> Remove all but the first include of sys/types.h from cs_prctl_test.c.
> 
> 'sys/wait.h' include in 'cs_prctl_test.c' is duplicated.
> Remove all but the first include of sys/wait.h from cs_prctl_test.c.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: yong yiran <yong.yiran@zte.com.cn>
> ---
>   tools/testing/selftests/sched/cs_prctl_test.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/sched/cs_prctl_test.c b/tools/testing/selftests/sched/cs_prctl_test.c
> index 63fe6521c56d..7db9cf822dc7 100644
> --- a/tools/testing/selftests/sched/cs_prctl_test.c
> +++ b/tools/testing/selftests/sched/cs_prctl_test.c
> @@ -25,8 +25,6 @@
>   #include <sys/types.h>
>   #include <sched.h>
>   #include <sys/prctl.h>
> -#include <sys/types.h>
> -#include <sys/wait.h>
>   #include <unistd.h>
>   #include <time.h>
>   #include <stdio.h>
> 

We can't accept this patch. The from and Signed-off-by don't match.

thanks,
-- Shuah
diff mbox series

Patch

diff --git a/tools/testing/selftests/sched/cs_prctl_test.c b/tools/testing/selftests/sched/cs_prctl_test.c
index 63fe6521c56d..7db9cf822dc7 100644
--- a/tools/testing/selftests/sched/cs_prctl_test.c
+++ b/tools/testing/selftests/sched/cs_prctl_test.c
@@ -25,8 +25,6 @@ 
 #include <sys/types.h>
 #include <sched.h>
 #include <sys/prctl.h>
-#include <sys/types.h>
-#include <sys/wait.h>
 #include <unistd.h>
 #include <time.h>
 #include <stdio.h>