| Message ID | 20210902084635.103622-1-lizhijian@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 92a59d7f381d2caf69385bfa00590028e32eea26 |
| Headers | show |
| Series | selftests/gpio: Fix gpio compiling error | expand |
applied On Thu, Sep 02, 2021 at 04:46:35PM +0800, Li Zhijian wrote: > [root@iaas-rpma gpio]# make > gcc gpio-mockup-cdev.c -o /home/lizhijian/linux/tools/testing/selftests/gpio/gpio-mockup-cdev > gpio-mockup-cdev.c: In function ‘request_line_v2’: > gpio-mockup-cdev.c:24:30: error: storage size of ‘req’ isn’t known > 24 | struct gpio_v2_line_request req; > | ^~~ > gpio-mockup-cdev.c:32:14: error: ‘GPIO_V2_LINE_FLAG_OUTPUT’ undeclared (first use in this function); did you mean ‘GPIOLINE_FLAG_IS_OUT’? > 32 | if (flags & GPIO_V2_LINE_FLAG_OUTPUT) { > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > Search headers from linux tree like others, such as sched > > CC: Philip Li <philip.li@intel.com> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> > --- > tools/testing/selftests/gpio/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile > index 39f2bbe8dd3d..42ea7d2aa844 100644 > --- a/tools/testing/selftests/gpio/Makefile > +++ b/tools/testing/selftests/gpio/Makefile > @@ -3,5 +3,6 @@ > TEST_PROGS := gpio-mockup.sh > TEST_FILES := gpio-mockup-sysfs.sh > TEST_GEN_PROGS_EXTENDED := gpio-mockup-cdev > +CFLAGS += -I../../../../usr/include > > include ../lib.mk > -- > 2.31.1 > > >
On Thu, Sep 02, 2021 at 05:39:18PM +0800, Philip Li wrote: > applied sorry, reply the wrong mail, kindly ignore > On Thu, Sep 02, 2021 at 04:46:35PM +0800, Li Zhijian wrote: > > [root@iaas-rpma gpio]# make > > gcc gpio-mockup-cdev.c -o /home/lizhijian/linux/tools/testing/selftests/gpio/gpio-mockup-cdev > > gpio-mockup-cdev.c: In function ‘request_line_v2’: > > gpio-mockup-cdev.c:24:30: error: storage size of ‘req’ isn’t known > > 24 | struct gpio_v2_line_request req; > > | ^~~ > > gpio-mockup-cdev.c:32:14: error: ‘GPIO_V2_LINE_FLAG_OUTPUT’ undeclared (first use in this function); did you mean ‘GPIOLINE_FLAG_IS_OUT’? > > 32 | if (flags & GPIO_V2_LINE_FLAG_OUTPUT) { > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > > Search headers from linux tree like others, such as sched > > > > CC: Philip Li <philip.li@intel.com> > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> > > --- > > tools/testing/selftests/gpio/Makefile | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile > > index 39f2bbe8dd3d..42ea7d2aa844 100644 > > --- a/tools/testing/selftests/gpio/Makefile > > +++ b/tools/testing/selftests/gpio/Makefile > > @@ -3,5 +3,6 @@ > > TEST_PROGS := gpio-mockup.sh > > TEST_FILES := gpio-mockup-sysfs.sh > > TEST_GEN_PROGS_EXTENDED := gpio-mockup-cdev > > +CFLAGS += -I../../../../usr/include > > > > include ../lib.mk > > -- > > 2.31.1 > > > > > >
On 9/2/21 2:46 AM, Li Zhijian wrote: I like to see the reason for this compile error followed by how it is fixed. > [root@iaas-rpma gpio]# make > gcc gpio-mockup-cdev.c -o /home/lizhijian/linux/tools/testing/selftests/gpio/gpio-mockup-cdev > gpio-mockup-cdev.c: In function ‘request_line_v2’: > gpio-mockup-cdev.c:24:30: error: storage size of ‘req’ isn’t known > 24 | struct gpio_v2_line_request req; > | ^~~ > gpio-mockup-cdev.c:32:14: error: ‘GPIO_V2_LINE_FLAG_OUTPUT’ undeclared (first use in this function); did you mean ‘GPIOLINE_FLAG_IS_OUT’? > 32 | if (flags & GPIO_V2_LINE_FLAG_OUTPUT) { > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > Search headers from linux tree like others, such as sched > > CC: Philip Li <philip.li@intel.com> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> > --- > tools/testing/selftests/gpio/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile > index 39f2bbe8dd3d..42ea7d2aa844 100644 > --- a/tools/testing/selftests/gpio/Makefile > +++ b/tools/testing/selftests/gpio/Makefile > @@ -3,5 +3,6 @@ > TEST_PROGS := gpio-mockup.sh > TEST_FILES := gpio-mockup-sysfs.sh > TEST_GEN_PROGS_EXTENDED := gpio-mockup-cdev > +CFLAGS += -I../../../../usr/include > > include ../lib.mk > thanks, -- Shuah
diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile index 39f2bbe8dd3d..42ea7d2aa844 100644 --- a/tools/testing/selftests/gpio/Makefile +++ b/tools/testing/selftests/gpio/Makefile @@ -3,5 +3,6 @@ TEST_PROGS := gpio-mockup.sh TEST_FILES := gpio-mockup-sysfs.sh TEST_GEN_PROGS_EXTENDED := gpio-mockup-cdev +CFLAGS += -I../../../../usr/include include ../lib.mk
[root@iaas-rpma gpio]# make gcc gpio-mockup-cdev.c -o /home/lizhijian/linux/tools/testing/selftests/gpio/gpio-mockup-cdev gpio-mockup-cdev.c: In function ‘request_line_v2’: gpio-mockup-cdev.c:24:30: error: storage size of ‘req’ isn’t known 24 | struct gpio_v2_line_request req; | ^~~ gpio-mockup-cdev.c:32:14: error: ‘GPIO_V2_LINE_FLAG_OUTPUT’ undeclared (first use in this function); did you mean ‘GPIOLINE_FLAG_IS_OUT’? 32 | if (flags & GPIO_V2_LINE_FLAG_OUTPUT) { | ^~~~~~~~~~~~~~~~~~~~~~~~ Search headers from linux tree like others, such as sched CC: Philip Li <philip.li@intel.com> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> --- tools/testing/selftests/gpio/Makefile | 1 + 1 file changed, 1 insertion(+)