From patchwork Fri Sep 17 12:08:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 12501759 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A627DC433EF for ; Fri, 17 Sep 2021 12:10:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FDF960F9C for ; Fri, 17 Sep 2021 12:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229923AbhIQML2 (ORCPT ); Fri, 17 Sep 2021 08:11:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:48180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbhIQML2 (ORCPT ); Fri, 17 Sep 2021 08:11:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0E82561029; Fri, 17 Sep 2021 12:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631880606; bh=yJ4ueh+BO+Eim5GlQAHvD/jC8/yyMw/A2pszTTlipf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fIt81/ZvyJWP6ElADvEl64I067AReSwhQeg0YZlHP+ugWr03sSLTbNwjqmhNTWGDh YJjsfZHED5nMmaBkvDNVHFVJUXdRlItJp5PzSShxAevHoSfieAAGSCv3HLL6YrPlBE /Av8Fmt3kvAh/L5HVQtbzC3G6dL34uATS3HcvJvd+yLXKqHiPsdt1OuBpJE3PXm53v Od/BDMKtHTXQ4fv8Z6J+tEhrn7+GqQl6wedfxmd9eYmJqUE8wQSjXBL3yWiMeN0gJU F+61KSmM3IN5xGLmiK2GcAov3ROo8ywnt5pvakEkLqCrnzQZ2Zt62xIX1HDvd8cvOZ ndke3FJNseR2g== From: Mark Brown To: Catalin Marinas , Will Deacon , Shuah Khan , Shuah Khan Cc: linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, misono.tomohiro@fujitsu.com, Mark Brown Subject: [PATCH v2 2/4] selftests: arm64: Remove bogus error check on writing to files Date: Fri, 17 Sep 2021 13:08:53 +0100 Message-Id: <20210917120855.13858-3-broonie@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210917120855.13858-1-broonie@kernel.org> References: <20210917120855.13858-1-broonie@kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1028; h=from:subject; bh=yJ4ueh+BO+Eim5GlQAHvD/jC8/yyMw/A2pszTTlipf8=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBhRIVTGHlxtnIY4Eu/5/J5cdKSDM5mRmL00dmRJpB8 pcoNJEyJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCYUSFUwAKCRAk1otyXVSH0AsnB/ 4uF8UuO/qc8eC2OvSne45kbXQK7H/UqOVOJdfbCbtJZ/Yg6SVz3EIkmHEbjFFFxPnDuDsKF361i/1q /ZZOUtDowrvahmjD40x96SQFrRrFSX+PLtMfJv1QfFzRfeNU0j3y0IsjL905+WdbiCMHg5qyGsJGPW JEzJ0ym76gMzopdWFf1CWa5P/qRcmxsxaksL/NSFz++NJhuCPHwdB7xUcwA0gcbiPrjYiw72ZPzjHI qds/4rUmG8hx8IzObBBrMt5e5HWbswz+gAZTQepCuJExjYyyZyfp4kwlhE3m/p4W1rbPm8/SQ5p/YN tHJBWupoGarDuXJOKp32YqJen54xX8 X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Due to some refactoring with the error handling we ended up mangling things so we never actually set ret and therefore shouldn't be checking it. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/vec-syscfg.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tools/testing/selftests/arm64/fp/vec-syscfg.c b/tools/testing/selftests/arm64/fp/vec-syscfg.c index b2de002ee325..d48d3ee1bc36 100644 --- a/tools/testing/selftests/arm64/fp/vec-syscfg.c +++ b/tools/testing/selftests/arm64/fp/vec-syscfg.c @@ -180,7 +180,6 @@ static int file_read_integer(const char *name, int *val) static int file_write_integer(const char *name, int val) { FILE *f; - int ret; f = fopen(name, "w"); if (!f) { @@ -192,11 +191,6 @@ static int file_write_integer(const char *name, int val) fprintf(f, "%d", val); fclose(f); - if (ret < 0) { - ksft_test_result_fail("Error writing %d to %s\n", - val, name); - return -1; - } return 0; }