| Message ID | 20211103201350.3866089-1-anders.roxell@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a21296a5111938e213503930d61139f3df902cb1 |
| Headers | show |
| Series | selftests: clone3: clone3: add case CLONE3_ARGS_NO_TEST | expand |
On Wed, Nov 03, 2021 at 09:13:50PM +0100, Anders Roxell wrote: > Building selftests/clone3 with clang warns about enumeration not handled > in switch case: > > clone3.c:54:10: warning: enumeration value 'CLONE3_ARGS_NO_TEST' not handled in switch [-Wswitch] > switch (test_mode) { > ^ > > Add the missing switch case with a comment. > > Fixes: 17a810699c18 ("selftests: add tests for clone3()") > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- Fine by me. Thanks! Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c index ede5da0c67b4..3fd49f419466 100644 --- a/tools/testing/selftests/clone3/clone3.c +++ b/tools/testing/selftests/clone3/clone3.c @@ -52,6 +52,12 @@ static int call_clone3(uint64_t flags, size_t size, enum test_mode test_mode) size = sizeof(struct __clone_args); switch (test_mode) { + case CLONE3_ARGS_NO_TEST: + /* + * Uses default 'flags' and 'SIGCHLD' + * assignment. + */ + break; case CLONE3_ARGS_ALL_0: args.flags = 0; args.exit_signal = 0;
Building selftests/clone3 with clang warns about enumeration not handled in switch case: clone3.c:54:10: warning: enumeration value 'CLONE3_ARGS_NO_TEST' not handled in switch [-Wswitch] switch (test_mode) { ^ Add the missing switch case with a comment. Fixes: 17a810699c18 ("selftests: add tests for clone3()") Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- tools/testing/selftests/clone3/clone3.c | 6 ++++++ 1 file changed, 6 insertions(+)