| Message ID | 20211206102931.1433871-1-anders.roxell@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] selftests: vDSO: parse: warning: fix assignment as a condition | expand |
On Mon, Dec 06, 2021 at 11:29:31AM +0100, Anders Roxell wrote: > When building selftests/vDSO with clang the following warning shows up: > > clang -std=gnu99 -Wno-pointer-sign vdso_test_gettimeofday.c parse_vdso.c \ > -o /tmp/kselftest/vDSO/vdso_test_gettimeofday > parse_vdso.c:65:9: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] > if (g = h & 0xf0000000) > ~~^~~~~~~~~~~~~~~~ > > Rework to a parentheses before doing the check. This part of the commit message does not line up with what you are actually doing now. > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> With that fixed: Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > > v1 -> v2: fixed checkpatch warnings > > tools/testing/selftests/vDSO/parse_vdso.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/vDSO/parse_vdso.c b/tools/testing/selftests/vDSO/parse_vdso.c > index 413f75620a35..fdd38f7e0e43 100644 > --- a/tools/testing/selftests/vDSO/parse_vdso.c > +++ b/tools/testing/selftests/vDSO/parse_vdso.c > @@ -62,7 +62,8 @@ static unsigned long elf_hash(const unsigned char *name) > while (*name) > { > h = (h << 4) + *name++; > - if (g = h & 0xf0000000) > + g = h & 0xf0000000; > + if (g) > h ^= g >> 24; > h &= ~g; > } > -- > 2.33.0 >
diff --git a/tools/testing/selftests/vDSO/parse_vdso.c b/tools/testing/selftests/vDSO/parse_vdso.c index 413f75620a35..fdd38f7e0e43 100644 --- a/tools/testing/selftests/vDSO/parse_vdso.c +++ b/tools/testing/selftests/vDSO/parse_vdso.c @@ -62,7 +62,8 @@ static unsigned long elf_hash(const unsigned char *name) while (*name) { h = (h << 4) + *name++; - if (g = h & 0xf0000000) + g = h & 0xf0000000; + if (g) h ^= g >> 24; h &= ~g; }
When building selftests/vDSO with clang the following warning shows up: clang -std=gnu99 -Wno-pointer-sign vdso_test_gettimeofday.c parse_vdso.c \ -o /tmp/kselftest/vDSO/vdso_test_gettimeofday parse_vdso.c:65:9: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] if (g = h & 0xf0000000) ~~^~~~~~~~~~~~~~~~ Rework to a parentheses before doing the check. Signed-off-by: Anders Roxell <anders.roxell@linaro.org> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> --- v1 -> v2: fixed checkpatch warnings tools/testing/selftests/vDSO/parse_vdso.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)