| Message ID | 20220114232126.92043-1-nfraprado@collabora.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | selftests: cpufreq: Write test output to stdout as well | expand |
On 14-01-22, 18:21, Nícolas F. R. A. Prado wrote: > Use 'tee' to send the test output to stdout in addition to the current > output file. This makes the output easier to handle in automated test > systems and is superior to only later dumping the output file contents > to stdout, since this way the test output can be interleaved with other > log messages, like from the kernel, so that chronology is preserved, > making it easier to detect issues. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > tools/testing/selftests/cpufreq/main.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/cpufreq/main.sh b/tools/testing/selftests/cpufreq/main.sh > index 31f8c9a76c5f..60ce18ed0666 100755 > --- a/tools/testing/selftests/cpufreq/main.sh > +++ b/tools/testing/selftests/cpufreq/main.sh > @@ -194,5 +194,5 @@ prerequisite > > # Run requested functions > clear_dumps $OUTFILE > -do_test >> $OUTFILE.txt > +do_test | tee -a $OUTFILE.txt > dmesg_dumps $OUTFILE Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On 1/16/22 11:41 PM, Viresh Kumar wrote: > On 14-01-22, 18:21, Nícolas F. R. A. Prado wrote: >> Use 'tee' to send the test output to stdout in addition to the current >> output file. This makes the output easier to handle in automated test >> systems and is superior to only later dumping the output file contents >> to stdout, since this way the test output can be interleaved with other >> log messages, like from the kernel, so that chronology is preserved, >> making it easier to detect issues. >> >> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> >> --- >> tools/testing/selftests/cpufreq/main.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/cpufreq/main.sh b/tools/testing/selftests/cpufreq/main.sh >> index 31f8c9a76c5f..60ce18ed0666 100755 >> --- a/tools/testing/selftests/cpufreq/main.sh >> +++ b/tools/testing/selftests/cpufreq/main.sh >> @@ -194,5 +194,5 @@ prerequisite >> >> # Run requested functions >> clear_dumps $OUTFILE >> -do_test >> $OUTFILE.txt >> +do_test | tee -a $OUTFILE.txt >> dmesg_dumps $OUTFILE > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > Thank you. Applied to linux-kselftest fixes for rc2/3 thanks, -- Shuah
diff --git a/tools/testing/selftests/cpufreq/main.sh b/tools/testing/selftests/cpufreq/main.sh index 31f8c9a76c5f..60ce18ed0666 100755 --- a/tools/testing/selftests/cpufreq/main.sh +++ b/tools/testing/selftests/cpufreq/main.sh @@ -194,5 +194,5 @@ prerequisite # Run requested functions clear_dumps $OUTFILE -do_test >> $OUTFILE.txt +do_test | tee -a $OUTFILE.txt dmesg_dumps $OUTFILE
Use 'tee' to send the test output to stdout in addition to the current output file. This makes the output easier to handle in automated test systems and is superior to only later dumping the output file contents to stdout, since this way the test output can be interleaved with other log messages, like from the kernel, so that chronology is preserved, making it easier to detect issues. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- tools/testing/selftests/cpufreq/main.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)