| Message ID | 20220119101531.2850400-9-usama.anjum@collabora.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5faa35d0b8cc1403acb6760e9e95905cfd691872 |
| Headers | show |
| Series | selftests: Fix separate output directory builds | expand |
Hi Muhammad, On 19/01/2022 11:15, Muhammad Usama Anjum wrote: > Out of tree build of this test fails if relative path of the output > directory is specified. Add the KHDR_INCLUDES to correctly reach the > headers. > > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > Changes in V2: > Revert the excessive cleanup which was breaking the individual > test build. Thank you for the v2, it looks safer that way and it no longer breaks our CI! Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net> Cheers, Matt
diff --git a/tools/testing/selftests/net/mptcp/Makefile b/tools/testing/selftests/net/mptcp/Makefile index 0356c4501c99..f905d5358e68 100644 --- a/tools/testing/selftests/net/mptcp/Makefile +++ b/tools/testing/selftests/net/mptcp/Makefile @@ -3,7 +3,7 @@ top_srcdir = ../../../../.. KSFT_KHDR_INSTALL := 1 -CFLAGS = -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include +CFLAGS = -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include $(KHDR_INCLUDES) TEST_PROGS := mptcp_connect.sh pm_netlink.sh mptcp_join.sh diag.sh \ simult_flows.sh mptcp_sockopt.sh
Out of tree build of this test fails if relative path of the output directory is specified. Add the KHDR_INCLUDES to correctly reach the headers. Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> --- Changes in V2: Revert the excessive cleanup which was breaking the individual test build. --- tools/testing/selftests/net/mptcp/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)