| Message ID | 20220210190642.1477814-3-usama.anjum@collabora.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6170abb21e2380477080b25145da9747ad467d3d |
| Headers | show |
| Series | selftests: sgx: Fix build of test_sgx | expand |
On 2/10/22 12:06 PM, Muhammad Usama Anjum wrote: > CC can have multiple sub-strings like "ccache gcc". For check_cc.sh, > CC needs to be treated like one argument. Put double quotes around it to > make CC one string and hence one argument. > > Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX") > Reported-by: "kernelci.org bot" <bot@kernelci.org> > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > tools/testing/selftests/sgx/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/sgx/Makefile b/tools/testing/selftests/sgx/Makefile > index 2956584e1e37f..75af864e07b65 100644 > --- a/tools/testing/selftests/sgx/Makefile > +++ b/tools/testing/selftests/sgx/Makefile > @@ -4,7 +4,7 @@ include ../lib.mk > > .PHONY: all clean > > -CAN_BUILD_X86_64 := $(shell ../x86/check_cc.sh $(CC) \ > +CAN_BUILD_X86_64 := $(shell ../x86/check_cc.sh "$(CC)" \ > ../x86/trivial_64bit_program.c) > > ifndef OBJCOPY > The intent is testing if $CC is set. Does this change work when $CC is not set? thanks, -- Shuah
On Fri, Feb 11, 2022 at 12:06:41AM +0500, Muhammad Usama Anjum wrote: > CC can have multiple sub-strings like "ccache gcc". For check_cc.sh, > CC needs to be treated like one argument. Put double quotes around it to > make CC one string and hence one argument. > > Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX") > Reported-by: "kernelci.org bot" <bot@kernelci.org> > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > tools/testing/selftests/sgx/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/sgx/Makefile b/tools/testing/selftests/sgx/Makefile > index 2956584e1e37f..75af864e07b65 100644 > --- a/tools/testing/selftests/sgx/Makefile > +++ b/tools/testing/selftests/sgx/Makefile > @@ -4,7 +4,7 @@ include ../lib.mk > > .PHONY: all clean > > -CAN_BUILD_X86_64 := $(shell ../x86/check_cc.sh $(CC) \ > +CAN_BUILD_X86_64 := $(shell ../x86/check_cc.sh "$(CC)" \ > ../x86/trivial_64bit_program.c) > > ifndef OBJCOPY > -- > 2.30.2 > Tested-by: Jarkko Sakkinen <jarkko@kernel.org> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> BR, Jarkko
diff --git a/tools/testing/selftests/sgx/Makefile b/tools/testing/selftests/sgx/Makefile index 2956584e1e37f..75af864e07b65 100644 --- a/tools/testing/selftests/sgx/Makefile +++ b/tools/testing/selftests/sgx/Makefile @@ -4,7 +4,7 @@ include ../lib.mk .PHONY: all clean -CAN_BUILD_X86_64 := $(shell ../x86/check_cc.sh $(CC) \ +CAN_BUILD_X86_64 := $(shell ../x86/check_cc.sh "$(CC)" \ ../x86/trivial_64bit_program.c) ifndef OBJCOPY
CC can have multiple sub-strings like "ccache gcc". For check_cc.sh, CC needs to be treated like one argument. Put double quotes around it to make CC one string and hence one argument. Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX") Reported-by: "kernelci.org bot" <bot@kernelci.org> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> --- tools/testing/selftests/sgx/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)