| Message ID | 20220227055330.43087-1-zhouchengming@bytedance.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] kselftest/vm: override TARGETS from arguments | expand |
On 2/26/22 10:53 PM, Chengming Zhou wrote: > We can specify which testcases to build using TARGETS argument, > for example: make -C tools/testing/selftests TARGETS=vm, cause > the ordinary assignment of TARGETS in Makefile will be ignored. > So we need to use override directive to change that. > > Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com> > --- > tools/testing/selftests/vm/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile > index 1607322a112c..0b330a5b1840 100644 > --- a/tools/testing/selftests/vm/Makefile > +++ b/tools/testing/selftests/vm/Makefile > @@ -53,7 +53,7 @@ CAN_BUILD_I386 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_32bit_progra > CAN_BUILD_X86_64 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_64bit_program.c) > CAN_BUILD_WITH_NOPIE := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_program.c -no-pie) > > -TARGETS := protection_keys > +override TARGETS := protection_keys > BINARIES_32 := $(TARGETS:%=%_32) > BINARIES_64 := $(TARGETS:%=%_64) > > Let's not override TARGETS - rename TARGETS in this file. VM_TARGETS? thanks, -- Shuah
On 2022/3/4 3:17 上午, Shuah Khan wrote: > On 2/26/22 10:53 PM, Chengming Zhou wrote: >> We can specify which testcases to build using TARGETS argument, >> for example: make -C tools/testing/selftests TARGETS=vm, cause >> the ordinary assignment of TARGETS in Makefile will be ignored. >> So we need to use override directive to change that. >> >> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com> >> --- >> tools/testing/selftests/vm/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile >> index 1607322a112c..0b330a5b1840 100644 >> --- a/tools/testing/selftests/vm/Makefile >> +++ b/tools/testing/selftests/vm/Makefile >> @@ -53,7 +53,7 @@ CAN_BUILD_I386 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_32bit_progra >> CAN_BUILD_X86_64 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_64bit_program.c) >> CAN_BUILD_WITH_NOPIE := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_program.c -no-pie) >> -TARGETS := protection_keys >> +override TARGETS := protection_keys >> BINARIES_32 := $(TARGETS:%=%_32) >> BINARIES_64 := $(TARGETS:%=%_64) >> > > Let's not override TARGETS - rename TARGETS in this file. > VM_TARGETS? Looks like Andrew has already added this patch to the -mm tree. I think both way is ok to solve this problem. Should I rename to VM_TARGETS and send another patch? Thanks. > > thanks, > -- Shuah
diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index 1607322a112c..0b330a5b1840 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -53,7 +53,7 @@ CAN_BUILD_I386 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_32bit_progra CAN_BUILD_X86_64 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_64bit_program.c) CAN_BUILD_WITH_NOPIE := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_program.c -no-pie) -TARGETS := protection_keys +override TARGETS := protection_keys BINARIES_32 := $(TARGETS:%=%_32) BINARIES_64 := $(TARGETS:%=%_64)
We can specify which testcases to build using TARGETS argument, for example: make -C tools/testing/selftests TARGETS=vm, cause the ordinary assignment of TARGETS in Makefile will be ignored. So we need to use override directive to change that. Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com> --- tools/testing/selftests/vm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)