From patchwork Fri Apr 29 18:12:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Latypov X-Patchwork-Id: 12832584 X-Patchwork-Delegate: brendanhiggins@google.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32F6AC433FE for ; Fri, 29 Apr 2022 18:13:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233327AbiD2SQg (ORCPT ); Fri, 29 Apr 2022 14:16:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379919AbiD2SQe (ORCPT ); Fri, 29 Apr 2022 14:16:34 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28F19C7497 for ; Fri, 29 Apr 2022 11:13:14 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id j11-20020a05690212cb00b006454988d225so7998827ybu.10 for ; Fri, 29 Apr 2022 11:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=sL4XXKW/JkXSCKlfCPPNQVCwhZjkWTkPQxVqGebWlkY=; b=J8I5/PjQmTyc7WXDivtsNpPPj3oCtvBdvBNDRZ016t+T537sEc6xywczIJjMi05DZh OT1tpJeA7Ys1Oalyk/Q7g8bQO3eNce6w6ztjAyvQGEW7zmxJZvQO6ZCtW+9Tie8pys5Q tgMFfSRBeh79U+MlvjO7SwoBhWU6fipFTqmjGEvrjTzjp51iImfSo4bPnFMHPC37HuzK +NUVBBR0ZgofOK61hfA1YC99wfQ0UpDi75zqTeBk2mysDTntcVYfxeM3lHA9iDwjCVmn DRjB0Xwxj7EMaeICNXQPuX77pluy0vvMfEFcJ1AgmId2Qgl9lIpd1K+HYiz68u2ZCc2F FLFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=sL4XXKW/JkXSCKlfCPPNQVCwhZjkWTkPQxVqGebWlkY=; b=T8O7QLpcTN+puOVJkCc+9AqjXK8ZNdx38eZjrP0jCoAwcsaheofzc1bvpUjQwudQUO 0e7xJgCcA57gunFXF4BGQlIXkQioL0qLdg9H12c1PAGI2B5oGdSEgCEqMUqTZoGrZmyA 0eOj4UGRXT8ySsUyaOD3+9bY3C+bRrfOfmPe0jqG0cv4iMLPqarPkGY0pFZdJqo70URS Lc8lrKM5AcdGtqbrY6wo2PmwaYYUkKwfnT0TnTSSFyaaf4QyHhRSMwl2st+DFTH+Gn9w uUIDAqAAwZab405+mSy88uS87d6XTR58HC88mDBvPA7m3TRb1thAzurc2NfDzKAnF1oF KE9g== X-Gm-Message-State: AOAM532K6BxDFfk0jj318XV+xIAP+zMlb+yc9pIygDqy2TP7VfZgu9+n x50sd2NpNEAAVlX/4hBsQe+YAhAcCdegoQ== X-Google-Smtp-Source: ABdhPJyyVRFTKlRDuFIct0JNB1b+NegMWENKiEyuTk/7a5uhOrU993QYfuCRnGk4qCfG6URZ47v+Y5zg7zypzw== X-Received: from dlatypov.svl.corp.google.com ([2620:15c:2cd:202:183a:36d7:2dcb:1773]) (user=dlatypov job=sendgmr) by 2002:a25:9383:0:b0:648:458e:423e with SMTP id a3-20020a259383000000b00648458e423emr669169ybm.583.1651255993442; Fri, 29 Apr 2022 11:13:13 -0700 (PDT) Date: Fri, 29 Apr 2022 11:12:59 -0700 In-Reply-To: <20220429181259.622060-1-dlatypov@google.com> Message-Id: <20220429181259.622060-4-dlatypov@google.com> Mime-Version: 1.0 References: <20220429181259.622060-1-dlatypov@google.com> X-Mailer: git-send-email 2.36.0.464.gb9c8b46e94-goog Subject: [PATCH v2 4/4] kunit: fix debugfs code to use enum kunit_status, not bool From: Daniel Latypov To: brendanhiggins@google.com, davidgow@google.com Cc: linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org, Daniel Latypov Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Commit 6d2426b2f258 ("kunit: Support skipped tests") switched to using `enum kunit_status` to track the result of running a test/suite since we now have more than just pass/fail. This callsite wasn't updated, silently converting to enum to a bool and then back. Fixes: 6d2426b2f258 ("kunit: Support skipped tests") Signed-off-by: Daniel Latypov Reviewed-by: Brendan Higgins --- v1 -> v2: added this patch. --- lib/kunit/debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kunit/debugfs.c b/lib/kunit/debugfs.c index b71db0abc12b..1048ef1b8d6e 100644 --- a/lib/kunit/debugfs.c +++ b/lib/kunit/debugfs.c @@ -52,7 +52,7 @@ static void debugfs_print_result(struct seq_file *seq, static int debugfs_print_results(struct seq_file *seq, void *v) { struct kunit_suite *suite = (struct kunit_suite *)seq->private; - bool success = kunit_suite_has_succeeded(suite); + enum kunit_status success = kunit_suite_has_succeeded(suite); struct kunit_case *test_case; if (!suite || !suite->log)