| Message ID | 20220704083426.1867401-1-usama.anjum@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | docs/kselftest: Fix build commands in guidelines | expand |
On 7/4/22 2:34 AM, Muhammad Usama Anjum wrote: > Build commands start with "make". It is missing. Add "make" to the start > of the build command. > > Fixes: 820636106342 ("docs/kselftest: add more guidelines for adding new tests") > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > Documentation/dev-tools/kselftest.rst | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst > index ee6467ca8293..9dd94c334f05 100644 > --- a/Documentation/dev-tools/kselftest.rst > +++ b/Documentation/dev-tools/kselftest.rst > @@ -255,9 +255,9 @@ Contributing new tests (details) > > * All changes should pass:: > > - kselftest-{all,install,clean,gen_tar} > - kselftest-{all,install,clean,gen_tar} O=abo_path > - kselftest-{all,install,clean,gen_tar} O=rel_path > + make kselftest-{all,install,clean,gen_tar} > + make kselftest-{all,install,clean,gen_tar} O=abs_path > + make kselftest-{all,install,clean,gen_tar} O=rel_path > make -C tools/testing/selftests {all,install,clean,gen_tar} > make -C tools/testing/selftests {all,install,clean,gen_tar} O=abs_path > make -C tools/testing/selftests {all,install,clean,gen_tar} O=rel_path > Looks like it depends on a patch already in doc tree? Acked-by: Shuah Khan <skhan@linuxfoundation.org> thanks, -- Shuah
On 7/8/22 9:51 PM, Shuah Khan wrote: > On 7/4/22 2:34 AM, Muhammad Usama Anjum wrote: >> Build commands start with "make". It is missing. Add "make" to the start >> of the build command. >> >> Fixes: 820636106342 ("docs/kselftest: add more guidelines for adding >> new tests") >> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> >> --- >> Documentation/dev-tools/kselftest.rst | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/dev-tools/kselftest.rst >> b/Documentation/dev-tools/kselftest.rst >> index ee6467ca8293..9dd94c334f05 100644 >> --- a/Documentation/dev-tools/kselftest.rst >> +++ b/Documentation/dev-tools/kselftest.rst >> @@ -255,9 +255,9 @@ Contributing new tests (details) >> * All changes should pass:: >> - kselftest-{all,install,clean,gen_tar} >> - kselftest-{all,install,clean,gen_tar} O=abo_path >> - kselftest-{all,install,clean,gen_tar} O=rel_path >> + make kselftest-{all,install,clean,gen_tar} >> + make kselftest-{all,install,clean,gen_tar} O=abs_path >> + make kselftest-{all,install,clean,gen_tar} O=rel_path >> make -C tools/testing/selftests {all,install,clean,gen_tar} >> make -C tools/testing/selftests {all,install,clean,gen_tar} >> O=abs_path >> make -C tools/testing/selftests {all,install,clean,gen_tar} >> O=rel_path >> > > Looks like it depends on a patch already in doc tree? Yes, the dependent patch is in doc tree. Corbet should pick up this patch. > Acked-by: Shuah Khan <skhan@linuxfoundation.org> > > thanks, > -- Shuah
On 7/26/22 9:59 AM, Muhammad Usama Anjum wrote: > On 7/8/22 9:51 PM, Shuah Khan wrote: >> On 7/4/22 2:34 AM, Muhammad Usama Anjum wrote: >>> Build commands start with "make". It is missing. Add "make" to the start >>> of the build command. >>> >>> Fixes: 820636106342 ("docs/kselftest: add more guidelines for adding >>> new tests") >>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> >>> --- >>> Documentation/dev-tools/kselftest.rst | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/Documentation/dev-tools/kselftest.rst >>> b/Documentation/dev-tools/kselftest.rst >>> index ee6467ca8293..9dd94c334f05 100644 >>> --- a/Documentation/dev-tools/kselftest.rst >>> +++ b/Documentation/dev-tools/kselftest.rst >>> @@ -255,9 +255,9 @@ Contributing new tests (details) >>> * All changes should pass:: >>> - kselftest-{all,install,clean,gen_tar} >>> - kselftest-{all,install,clean,gen_tar} O=abo_path >>> - kselftest-{all,install,clean,gen_tar} O=rel_path >>> + make kselftest-{all,install,clean,gen_tar} >>> + make kselftest-{all,install,clean,gen_tar} O=abs_path >>> + make kselftest-{all,install,clean,gen_tar} O=rel_path >>> make -C tools/testing/selftests {all,install,clean,gen_tar} >>> make -C tools/testing/selftests {all,install,clean,gen_tar} >>> O=abs_path >>> make -C tools/testing/selftests {all,install,clean,gen_tar} >>> O=rel_path >>> >> >> Looks like it depends on a patch already in doc tree? > Yes, the dependent patch is in doc tree. Corbet should pick up this patch. Reminder! >> Acked-by: Shuah Khan <skhan@linuxfoundation.org> >> >> thanks, >> -- Shuah >
diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst index ee6467ca8293..9dd94c334f05 100644 --- a/Documentation/dev-tools/kselftest.rst +++ b/Documentation/dev-tools/kselftest.rst @@ -255,9 +255,9 @@ Contributing new tests (details) * All changes should pass:: - kselftest-{all,install,clean,gen_tar} - kselftest-{all,install,clean,gen_tar} O=abo_path - kselftest-{all,install,clean,gen_tar} O=rel_path + make kselftest-{all,install,clean,gen_tar} + make kselftest-{all,install,clean,gen_tar} O=abs_path + make kselftest-{all,install,clean,gen_tar} O=rel_path make -C tools/testing/selftests {all,install,clean,gen_tar} make -C tools/testing/selftests {all,install,clean,gen_tar} O=abs_path make -C tools/testing/selftests {all,install,clean,gen_tar} O=rel_path
Build commands start with "make". It is missing. Add "make" to the start of the build command. Fixes: 820636106342 ("docs/kselftest: add more guidelines for adding new tests") Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> --- Documentation/dev-tools/kselftest.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)