| Message ID | 20220713204623.5443-9-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | selftests: timers: fixes and improvements | expand |
On Wed, Jul 13, 2022 at 1:46 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > So the user can decide how long the test should run. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > tools/testing/selftests/timers/clocksource-switch.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/timers/clocksource-switch.c b/tools/testing/selftests/timers/clocksource-switch.c > index 5256e6215980..a1d0d33738b6 100644 > --- a/tools/testing/selftests/timers/clocksource-switch.c > +++ b/tools/testing/selftests/timers/clocksource-switch.c > @@ -124,14 +124,18 @@ int main(int argc, char **argv) > char orig_clk[512]; > int count, i, status, opt; > int do_sanity_check = 1; > + int runtime = 60; > pid_t pid; > > /* Process arguments */ > - while ((opt = getopt(argc, argv, "s")) != -1) { > + while ((opt = getopt(argc, argv, "st:")) != -1) { > switch (opt) { > case 's': > do_sanity_check = 0; > break; > + case 't': > + runtime = atoi(optarg); > + break; > default: > printf("Usage: %s [-s]\n", argv[0]); > printf(" -s: skip sanity checks\n"); Ah, one minor nit: Should the -t option get documented here in the usage output? thanks again! -john
Hello! On 7/13/22 11:46 PM, Wolfram Sang wrote: > So the user can decide how long the test should run. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > tools/testing/selftests/timers/clocksource-switch.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/timers/clocksource-switch.c b/tools/testing/selftests/timers/clocksource-switch.c > index 5256e6215980..a1d0d33738b6 100644 > --- a/tools/testing/selftests/timers/clocksource-switch.c > +++ b/tools/testing/selftests/timers/clocksource-switch.c [...] > - while ((opt = getopt(argc, argv, "s")) != -1) { > + while ((opt = getopt(argc, argv, "st:")) != -1) { > switch (opt) { > case 's': > do_sanity_check = 0; > break; > + case 't': > + runtime = atoi(optarg); > + break; > default: > printf("Usage: %s [-s]\n", argv[0]); > printf(" -s: skip sanity checks\n"); Hm, you probably forgot to update the usage msg? [...] MBR, Sergey
> > default: > > printf("Usage: %s [-s]\n", argv[0]); > > printf(" -s: skip sanity checks\n"); > > Hm, you probably forgot to update the usage msg? Yup, thanks!
diff --git a/tools/testing/selftests/timers/clocksource-switch.c b/tools/testing/selftests/timers/clocksource-switch.c index 5256e6215980..a1d0d33738b6 100644 --- a/tools/testing/selftests/timers/clocksource-switch.c +++ b/tools/testing/selftests/timers/clocksource-switch.c @@ -124,14 +124,18 @@ int main(int argc, char **argv) char orig_clk[512]; int count, i, status, opt; int do_sanity_check = 1; + int runtime = 60; pid_t pid; /* Process arguments */ - while ((opt = getopt(argc, argv, "s")) != -1) { + while ((opt = getopt(argc, argv, "st:")) != -1) { switch (opt) { case 's': do_sanity_check = 0; break; + case 't': + runtime = atoi(optarg); + break; default: printf("Usage: %s [-s]\n", argv[0]); printf(" -s: skip sanity checks\n"); @@ -167,7 +171,7 @@ int main(int argc, char **argv) printf("Running Asynchronous Switching Tests...\n"); pid = fork(); if (!pid) - return run_tests(60); + return run_tests(runtime); while (pid != waitpid(pid, &status, WNOHANG)) for (i = 0; i < count; i++)
So the user can decide how long the test should run. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- tools/testing/selftests/timers/clocksource-switch.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)