diff mbox series

kunit: remove unused structure definition

Message ID 20221025015946.3186777-1-her0gyugyu@gmail.com (mailing list archive)
State Accepted
Commit 8f8b51f7d5c8bd3a89e7ea87aed2cdaa52ca5ba4
Delegated to: Brendan Higgins
Headers show
Series kunit: remove unused structure definition | expand

Commit Message

YoungJun.park Oct. 25, 2022, 1:59 a.m. UTC
remove unused string_stream_alloc_context structure definition.

Signed-off-by: YoungJun.park <her0gyugyu@gmail.com>
---
 lib/kunit/string-stream.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

David Gow Oct. 25, 2022, 4:19 a.m. UTC | #1
On Tue, Oct 25, 2022 at 9:59 AM YoungJun.park <her0gyugyu@gmail.com> wrote:
>
> remove unused string_stream_alloc_context structure definition.
>
> Signed-off-by: YoungJun.park <her0gyugyu@gmail.com>
> ---

Thanks for catching this! It looks like we remembered to get rid of
the related struct string_stream_fragment_alloc_context, but missed
this one.

Reviewed-by: David Gow <davidgow@google.com>
Fixes: 78b1c6584fce ("kunit: string-stream: Simplify resource use")

Cheers,
-- David

>  lib/kunit/string-stream.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/lib/kunit/string-stream.c b/lib/kunit/string-stream.c
> index f5ae79c37400..72659a9773e3 100644
> --- a/lib/kunit/string-stream.c
> +++ b/lib/kunit/string-stream.c
> @@ -131,11 +131,6 @@ bool string_stream_is_empty(struct string_stream *stream)
>         return list_empty(&stream->fragments);
>  }
>
> -struct string_stream_alloc_context {
> -       struct kunit *test;
> -       gfp_t gfp;
> -};
> -
>  struct string_stream *alloc_string_stream(struct kunit *test, gfp_t gfp)
>  {
>         struct string_stream *stream;
> --
> 2.25.1
>
diff mbox series

Patch

diff --git a/lib/kunit/string-stream.c b/lib/kunit/string-stream.c
index f5ae79c37400..72659a9773e3 100644
--- a/lib/kunit/string-stream.c
+++ b/lib/kunit/string-stream.c
@@ -131,11 +131,6 @@  bool string_stream_is_empty(struct string_stream *stream)
 	return list_empty(&stream->fragments);
 }
 
-struct string_stream_alloc_context {
-	struct kunit *test;
-	gfp_t gfp;
-};
-
 struct string_stream *alloc_string_stream(struct kunit *test, gfp_t gfp)
 {
 	struct string_stream *stream;