| Message ID | 20221105110443.23872-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e8f50c4f0c14214b6430b8b3493654a286681a2b |
| Headers | show |
| Series | selftests/xsk: Fix unsigned comparison with less than zero | expand |
someone has post a fix, pls ignore this. On 2022/11/5 19:04, YueHaibing wrote: > poll() may return negative on error, 'ret' should be int. > > Fixes: 3143d10b0945 ("selftests/xsk: Update poll test cases") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > tools/testing/selftests/bpf/xskxceiver.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selftests/bpf/xskxceiver.c > index 681a5db80dae..162d3a516f2c 100644 > --- a/tools/testing/selftests/bpf/xskxceiver.c > +++ b/tools/testing/selftests/bpf/xskxceiver.c > @@ -1006,7 +1006,8 @@ static int __send_pkts(struct ifobject *ifobject, u32 *pkt_nb, struct pollfd *fd > { > struct xsk_socket_info *xsk = ifobject->xsk; > bool use_poll = ifobject->use_poll; > - u32 i, idx = 0, ret, valid_pkts = 0; > + u32 i, idx = 0, valid_pkts = 0; > + int ret; > > while (xsk_ring_prod__reserve(&xsk->tx, BATCH_SIZE, &idx) < BATCH_SIZE) { > if (use_poll) {
diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selftests/bpf/xskxceiver.c index 681a5db80dae..162d3a516f2c 100644 --- a/tools/testing/selftests/bpf/xskxceiver.c +++ b/tools/testing/selftests/bpf/xskxceiver.c @@ -1006,7 +1006,8 @@ static int __send_pkts(struct ifobject *ifobject, u32 *pkt_nb, struct pollfd *fd { struct xsk_socket_info *xsk = ifobject->xsk; bool use_poll = ifobject->use_poll; - u32 i, idx = 0, ret, valid_pkts = 0; + u32 i, idx = 0, valid_pkts = 0; + int ret; while (xsk_ring_prod__reserve(&xsk->tx, BATCH_SIZE, &idx) < BATCH_SIZE) { if (use_poll) {
poll() may return negative on error, 'ret' should be int. Fixes: 3143d10b0945 ("selftests/xsk: Update poll test cases") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- tools/testing/selftests/bpf/xskxceiver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)