| Message ID | 20230111-kselftest-lib-clang-fix-v1-1-58ebadd0e090@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9fdaca2c1e157dc0a3c0faecf3a6a68e7d8d0c7b |
| Headers | show |
| Series | kselftest: Fix error message for unconfigured LLVM builds | expand |
On 1/11/23 15:33, Mark Brown wrote: > We are missing a ) when we attempt to complain about not having enough > configuration for clang, resulting in the rather inscrutable error: > > ../lib.mk:23: *** unterminated call to function 'error': missing ')'. Stop. > > Add the required ) so we print the message we were trying to print. > > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > tools/testing/selftests/lib.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index 291144c284fb..f7900e75d230 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -20,7 +20,7 @@ CLANG_TARGET_FLAGS := $(CLANG_TARGET_FLAGS_$(ARCH)) > > ifeq ($(CROSS_COMPILE),) > ifeq ($(CLANG_TARGET_FLAGS),) > -$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk > +$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk) > else > CLANG_FLAGS += --target=$(CLANG_TARGET_FLAGS) > endif # CLANG_TARGET_FLAGS > > --- > base-commit: b7bfaa761d760e72a969d116517eaa12e404c262 > change-id: 20230111-kselftest-lib-clang-fix-8936ba376ea1 > > Best regards, Thank you. I will queue this up for the next rc. thanks, -- Shuah
diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk index 291144c284fb..f7900e75d230 100644 --- a/tools/testing/selftests/lib.mk +++ b/tools/testing/selftests/lib.mk @@ -20,7 +20,7 @@ CLANG_TARGET_FLAGS := $(CLANG_TARGET_FLAGS_$(ARCH)) ifeq ($(CROSS_COMPILE),) ifeq ($(CLANG_TARGET_FLAGS),) -$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk +$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk) else CLANG_FLAGS += --target=$(CLANG_TARGET_FLAGS) endif # CLANG_TARGET_FLAGS
We are missing a ) when we attempt to complain about not having enough configuration for clang, resulting in the rather inscrutable error: ../lib.mk:23: *** unterminated call to function 'error': missing ')'. Stop. Add the required ) so we print the message we were trying to print. Signed-off-by: Mark Brown <broonie@kernel.org> --- tools/testing/selftests/lib.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: b7bfaa761d760e72a969d116517eaa12e404c262 change-id: 20230111-kselftest-lib-clang-fix-8936ba376ea1 Best regards,