| Message ID | 20230516184924.153498-1-bpoirier@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9ba9485b87ac97fd159abdb4cbd53099bc9f01c6 |
| Headers | show |
| Series | [net] net: selftests: Fix optstring | expand |
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Tue, 16 May 2023 14:49:24 -0400 you wrote: > The cited commit added a stray colon to the 'v' option. That makes the > option work incorrectly. > > ex: > tools/testing/selftests/net# ./fib_nexthops.sh -v > (should enable verbose mode, instead it shows help text due to missing arg) > > [...] Here is the summary with links: - [net] net: selftests: Fix optstring https://git.kernel.org/netdev/net/c/9ba9485b87ac You are awesome, thank you!
diff --git a/tools/testing/selftests/net/fib_nexthops.sh b/tools/testing/selftests/net/fib_nexthops.sh index a47b26ab48f2..0f5e88c8f4ff 100755 --- a/tools/testing/selftests/net/fib_nexthops.sh +++ b/tools/testing/selftests/net/fib_nexthops.sh @@ -2283,7 +2283,7 @@ EOF ################################################################################ # main -while getopts :t:pP46hv:w: o +while getopts :t:pP46hvw: o do case $o in t) TESTS=$OPTARG;;
The cited commit added a stray colon to the 'v' option. That makes the option work incorrectly. ex: tools/testing/selftests/net# ./fib_nexthops.sh -v (should enable verbose mode, instead it shows help text due to missing arg) Fixes: 5feba4727395 ("selftests: fib_nexthops: Make ping timeout configurable") Reviewed-by: Ido Schimmel <idosch@nvidia.com> Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com> --- tools/testing/selftests/net/fib_nexthops.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)