| Message ID | 20230707081253.34638-1-luhongfei@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 856fe03d929205b4c8c8fa51296342cd85592e3f |
| Headers | show |
| Series | [v2,bpf-next] selftests/bpf: Corrected two typos | expand |
On 7/7/2023 4:12 PM, Lu Hongfei wrote: > When wrapping code, use ';' better than using ',' which is more > in line with the coding habits of most engineers. > > Signed-off-by: Lu Hongfei <luhongfei@vivo.com> > --- > Compared to the previous version, the modifications made are: > 1. Modified the subject to make it clearer and more accurate > 2. Newly optimized typo in tcp_hdr_options.c > > tools/testing/selftests/bpf/benchs/bench_ringbufs.c | 2 +- > tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Acked-by: Hou Tao <houtao1@huawei.com>
On 07/07, Hou Tao wrote: > > > On 7/7/2023 4:12 PM, Lu Hongfei wrote: > > When wrapping code, use ';' better than using ',' which is more > > in line with the coding habits of most engineers. > > > > Signed-off-by: Lu Hongfei <luhongfei@vivo.com> > > --- > > Compared to the previous version, the modifications made are: > > 1. Modified the subject to make it clearer and more accurate > > 2. Newly optimized typo in tcp_hdr_options.c > > > > tools/testing/selftests/bpf/benchs/bench_ringbufs.c | 2 +- > > tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > Acked-by: Hou Tao <houtao1@huawei.com> Acked-by: Stanislav Fomichev <sdf@google.com>
Hello: This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <daniel@iogearbox.net>: On Fri, 7 Jul 2023 16:12:50 +0800 you wrote: > When wrapping code, use ';' better than using ',' which is more > in line with the coding habits of most engineers. > > Signed-off-by: Lu Hongfei <luhongfei@vivo.com> > --- > Compared to the previous version, the modifications made are: > 1. Modified the subject to make it clearer and more accurate > 2. Newly optimized typo in tcp_hdr_options.c > > [...] Here is the summary with links: - [v2,bpf-next] selftests/bpf: Corrected two typos https://git.kernel.org/bpf/bpf-next/c/856fe03d9292 You are awesome, thank you!
diff --git a/tools/testing/selftests/bpf/benchs/bench_ringbufs.c b/tools/testing/selftests/bpf/benchs/bench_ringbufs.c index 3ca14ad36607..e1ee979e6acc 100644 --- a/tools/testing/selftests/bpf/benchs/bench_ringbufs.c +++ b/tools/testing/selftests/bpf/benchs/bench_ringbufs.c @@ -399,7 +399,7 @@ static void perfbuf_libbpf_setup(void) ctx->skel = perfbuf_setup_skeleton(); memset(&attr, 0, sizeof(attr)); - attr.config = PERF_COUNT_SW_BPF_OUTPUT, + attr.config = PERF_COUNT_SW_BPF_OUTPUT; attr.type = PERF_TYPE_SOFTWARE; attr.sample_type = PERF_SAMPLE_RAW; /* notify only every Nth sample */ diff --git a/tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c b/tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c index 13bcaeb028b8..56685fc03c7e 100644 --- a/tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c +++ b/tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c @@ -347,7 +347,7 @@ static void syncookie_estab(void) exp_active_estab_in.max_delack_ms = 22; exp_passive_hdr_stg.syncookie = true; - exp_active_hdr_stg.resend_syn = true, + exp_active_hdr_stg.resend_syn = true; prepare_out();
When wrapping code, use ';' better than using ',' which is more in line with the coding habits of most engineers. Signed-off-by: Lu Hongfei <luhongfei@vivo.com> --- Compared to the previous version, the modifications made are: 1. Modified the subject to make it clearer and more accurate 2. Newly optimized typo in tcp_hdr_options.c tools/testing/selftests/bpf/benchs/bench_ringbufs.c | 2 +- tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)