| Message ID | 20230919011637.16483-1-nicolinc@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bb812e0069ce5de9af2a7910951c8c95632cebe3 |
| Headers | show |
| Series | iommufd/selftest: Iterate idev_ids in mock_domain's alloc_hwpt test | expand |
> From: Nicolin Chen <nicolinc@nvidia.com> > Sent: Tuesday, September 19, 2023 9:17 AM > > The point in iterating variant->mock_domains is to test the idev_ids[0] > and idev_ids[1]. So use it instead of keeping testing idev_ids[0] only. > > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
On Mon, Sep 18, 2023 at 06:16:37PM -0700, Nicolin Chen wrote: > The point in iterating variant->mock_domains is to test the idev_ids[0] > and idev_ids[1]. So use it instead of keeping testing idev_ids[0] only. > > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com> > --- > Jason/Kevin, I formated the patch with "-U4" so it shows the "for" line. > I didn't send it as a bug fix since it doesn't feel so critical that it > should bother stable trees -- yet if there's a need, I'd resend. Thanks! > > tools/testing/selftests/iommu/iommufd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to iommufd for-next Thanks, Jason
diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selftests/iommu/iommufd.c index 33d08600be13..9f705c1ea30f 100644 --- a/tools/testing/selftests/iommu/iommufd.c +++ b/tools/testing/selftests/iommu/iommufd.c @@ -1406,9 +1406,9 @@ TEST_F(iommufd_mock_domain, alloc_hwpt) for (i = 0; i != variant->mock_domains; i++) { uint32_t stddev_id; uint32_t hwpt_id; - test_cmd_hwpt_alloc(self->idev_ids[0], self->ioas_id, &hwpt_id); + test_cmd_hwpt_alloc(self->idev_ids[i], self->ioas_id, &hwpt_id); test_cmd_mock_domain(hwpt_id, &stddev_id, NULL, NULL); test_ioctl_destroy(stddev_id); test_ioctl_destroy(hwpt_id); }
The point in iterating variant->mock_domains is to test the idev_ids[0] and idev_ids[1]. So use it instead of keeping testing idev_ids[0] only. Signed-off-by: Nicolin Chen <nicolinc@nvidia.com> --- Jason/Kevin, I formated the patch with "-U4" so it shows the "for" line. I didn't send it as a bug fix since it doesn't feel so critical that it should bother stable trees -- yet if there's a need, I'd resend. Thanks! tools/testing/selftests/iommu/iommufd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)