diff mbox series

[1/2] arch: um: Add Clang coverage support

Message ID 20231020092159.2486063-2-michal.winiarski@intel.com (mailing list archive)
State Accepted
Commit 32a84cfc6caf830431375c5182391284986d4066
Headers show
Series um: kunit: Add Clang support for CONFIG_GCOV | expand

Commit Message

Michał Winiarski Oct. 20, 2023, 9:21 a.m. UTC
Clang uses a different set of command line arguments for enabling
coverage.

Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
---
 arch/um/Makefile-skas | 5 +++++
 1 file changed, 5 insertions(+)

Comments

David Gow Oct. 25, 2023, 8:25 a.m. UTC | #1
On Fri, 20 Oct 2023 at 17:22, Michał Winiarski
<michal.winiarski@intel.com> wrote:
>
> Clang uses a different set of command line arguments for enabling
> coverage.
>
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
> ---

This works brilliantly here -- I'm very glad to finally be able to use
something newer than gcc 6!

I assume this will go in via the UML tree, but if you want, we can
take it via KUnit.

Tested-by: David Gow <davidgow@google.com>

Cheers,
-- David


>  arch/um/Makefile-skas | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/um/Makefile-skas b/arch/um/Makefile-skas
> index ac35de5316a6..67323b028999 100644
> --- a/arch/um/Makefile-skas
> +++ b/arch/um/Makefile-skas
> @@ -4,7 +4,12 @@
>  #
>
>  GPROF_OPT += -pg
> +
> +ifdef CONFIG_CC_IS_CLANG
> +GCOV_OPT += -fprofile-instr-generate -fcoverage-mapping
> +else
>  GCOV_OPT += -fprofile-arcs -ftest-coverage
> +endif
>
>  CFLAGS-$(CONFIG_GCOV) += $(GCOV_OPT)
>  CFLAGS-$(CONFIG_GPROF) += $(GPROF_OPT)
> --
> 2.42.0
>
diff mbox series

Patch

diff --git a/arch/um/Makefile-skas b/arch/um/Makefile-skas
index ac35de5316a6..67323b028999 100644
--- a/arch/um/Makefile-skas
+++ b/arch/um/Makefile-skas
@@ -4,7 +4,12 @@ 
 #
 
 GPROF_OPT += -pg
+
+ifdef CONFIG_CC_IS_CLANG
+GCOV_OPT += -fprofile-instr-generate -fcoverage-mapping
+else
 GCOV_OPT += -fprofile-arcs -ftest-coverage
+endif
 
 CFLAGS-$(CONFIG_GCOV) += $(GCOV_OPT)
 CFLAGS-$(CONFIG_GPROF) += $(GPROF_OPT)