| Message ID | 20231022113148.2682-1-swarupkotikalapudi@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | selftests:net change ifconfig with ip command | expand |
On 10/22/23 5:31 AM, Swarup Laxman Kotiaklapudi wrote: > diff --git a/tools/testing/selftests/net/route_localnet.sh b/tools/testing/selftests/net/route_localnet.sh > index 116bfeab72fa..3ab9beb4462c 100755 > --- a/tools/testing/selftests/net/route_localnet.sh > +++ b/tools/testing/selftests/net/route_localnet.sh > @@ -18,8 +18,10 @@ setup() { > ip route del 127.0.0.0/8 dev lo table local > ip netns exec "${PEER_NS}" ip route del 127.0.0.0/8 dev lo table local > > - ifconfig veth0 127.25.3.4/24 up > - ip netns exec "${PEER_NS}" ifconfig veth1 127.25.3.14/24 up > + ip a add 127.25.3.4/24 dev veth0 ip addr add ... > + ip link set dev veth0 up > + ip netns exec "${PEER_NS}" ip a add 127.25.3.14/24 dev veth1 ip addr add ... > + ip netns exec "${PEER_NS}" ip link set dev veth1 up > > ip route flush cache > ip netns exec "${PEER_NS}" ip route flush cache
Sun, Oct 22, 2023 at 07:50:52PM CEST, dsahern@kernel.org wrote: >On 10/22/23 5:31 AM, Swarup Laxman Kotiaklapudi wrote: >> diff --git a/tools/testing/selftests/net/route_localnet.sh b/tools/testing/selftests/net/route_localnet.sh >> index 116bfeab72fa..3ab9beb4462c 100755 >> --- a/tools/testing/selftests/net/route_localnet.sh >> +++ b/tools/testing/selftests/net/route_localnet.sh >> @@ -18,8 +18,10 @@ setup() { >> ip route del 127.0.0.0/8 dev lo table local >> ip netns exec "${PEER_NS}" ip route del 127.0.0.0/8 dev lo table local >> >> - ifconfig veth0 127.25.3.4/24 up >> - ip netns exec "${PEER_NS}" ifconfig veth1 127.25.3.14/24 up >> + ip a add 127.25.3.4/24 dev veth0 > >ip addr add ... Why not "address" then? :) What's wrong with "a"? > >> + ip link set dev veth0 up >> + ip netns exec "${PEER_NS}" ip a add 127.25.3.14/24 dev veth1 > >ip addr add ... > >> + ip netns exec "${PEER_NS}" ip link set dev veth1 up >> >> ip route flush cache >> ip netns exec "${PEER_NS}" ip route flush cache > >
On 10/23/23 1:12 AM, Jiri Pirko wrote: >> ip addr add ... > > Why not "address" then? :) no objection from me. > What's wrong with "a"? 1-letter commands can be ambiguous. Test scripts should be clear and obvious.
diff --git a/tools/testing/selftests/net/route_localnet.sh b/tools/testing/selftests/net/route_localnet.sh index 116bfeab72fa..3ab9beb4462c 100755 --- a/tools/testing/selftests/net/route_localnet.sh +++ b/tools/testing/selftests/net/route_localnet.sh @@ -18,8 +18,10 @@ setup() { ip route del 127.0.0.0/8 dev lo table local ip netns exec "${PEER_NS}" ip route del 127.0.0.0/8 dev lo table local - ifconfig veth0 127.25.3.4/24 up - ip netns exec "${PEER_NS}" ifconfig veth1 127.25.3.14/24 up + ip a add 127.25.3.4/24 dev veth0 + ip link set dev veth0 up + ip netns exec "${PEER_NS}" ip a add 127.25.3.14/24 dev veth1 + ip netns exec "${PEER_NS}" ip link set dev veth1 up ip route flush cache ip netns exec "${PEER_NS}" ip route flush cache
Change ifconfig with ip command, on a system where ifconfig is not used this script will not work correcly. Test result with this patchset: sudo make TARGETS="net" kselftest .... TAP version 13 1..1 timeout set to 1500 selftests: net: route_localnet.sh run arp_announce test net.ipv4.conf.veth0.route_localnet = 1 net.ipv4.conf.veth1.route_localnet = 1 net.ipv4.conf.veth0.arp_announce = 2 net.ipv4.conf.veth1.arp_announce = 2 PING 127.25.3.14 (127.25.3.14) from 127.25.3.4 veth0: 56(84) bytes of data. 64 bytes from 127.25.3.14: icmp_seq=1 ttl=64 time=0.038 ms 64 bytes from 127.25.3.14: icmp_seq=2 ttl=64 time=0.068 ms 64 bytes from 127.25.3.14: icmp_seq=3 ttl=64 time=0.068 ms 64 bytes from 127.25.3.14: icmp_seq=4 ttl=64 time=0.068 ms 64 bytes from 127.25.3.14: icmp_seq=5 ttl=64 time=0.068 ms --- 127.25.3.14 ping statistics --- 5 packets transmitted, 5 received, 0% packet loss, time 4073ms rtt min/avg/max/mdev = 0.038/0.062/0.068/0.012 ms ok run arp_ignore test net.ipv4.conf.veth0.route_localnet = 1 net.ipv4.conf.veth1.route_localnet = 1 net.ipv4.conf.veth0.arp_ignore = 3 net.ipv4.conf.veth1.arp_ignore = 3 PING 127.25.3.14 (127.25.3.14) from 127.25.3.4 veth0: 56(84) bytes of data. 64 bytes from 127.25.3.14: icmp_seq=1 ttl=64 time=0.032 ms 64 bytes from 127.25.3.14: icmp_seq=2 ttl=64 time=0.065 ms 64 bytes from 127.25.3.14: icmp_seq=3 ttl=64 time=0.066 ms 64 bytes from 127.25.3.14: icmp_seq=4 ttl=64 time=0.065 ms 64 bytes from 127.25.3.14: icmp_seq=5 ttl=64 time=0.065 ms --- 127.25.3.14 ping statistics --- 5 packets transmitted, 5 received, 0% packet loss, time 4092ms rtt min/avg/max/mdev = 0.032/0.058/0.066/0.013 ms ok ok 1 selftests: net: route_localnet.sh ... Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com> --- tools/testing/selftests/net/route_localnet.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)