| Message ID | 20240110141436.157419-3-bpoirier@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6685aadcab8f170ae3e4d508989a85c1b8a58dba |
| Headers | show |
| Series | selftests: net: Small fixes | expand |
On Wed, 2024-01-10 at 09:14 -0500, Benjamin Poirier wrote: > The lib.sh script is meant to be sourced from other scripts, not executed > directly. Therefore, remove the executable bits from lib.sh's permissions. LGTM, but there is any special reason to not fix the permissions of other *lib.sh files in the same directory? Could be a follow-up. Thanks! Paolo
On 2024-01-16 09:32 +0100, Paolo Abeni wrote: > On Wed, 2024-01-10 at 09:14 -0500, Benjamin Poirier wrote: > > The lib.sh script is meant to be sourced from other scripts, not executed > > directly. Therefore, remove the executable bits from lib.sh's permissions. > > LGTM, but there is any special reason to not fix the permissions of > other *lib.sh files in the same directory? Could be a follow-up. I just looked into it and as of dbc153fd3c14 other *lib.sh files under tools/testing/selftests/net/forwarding/ do not have any executable bits. Did I miss something? tools/testing/selftests/net/setup_loopback.sh has an unneccessary +x, I'll send a patch for that one.
diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
old mode 100755
new mode 100644
The lib.sh script is meant to be sourced from other scripts, not executed directly. Therefore, remove the executable bits from lib.sh's permissions. Fixes: fe32dffdcd33 ("selftests: forwarding: add TCPDUMP_EXTRA_FLAGS to lib.sh") Tested-by: Hangbin Liu <liuhangbin@gmail.com> Reviewed-by: Hangbin Liu <liuhangbin@gmail.com> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com> --- tools/testing/selftests/net/forwarding/lib.sh | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 tools/testing/selftests/net/forwarding/lib.sh