diff mbox series

[net] selftests: tcp_ao: add a config file

Message ID 20240124192550.1865743-1-kuba@kernel.org (mailing list archive)
State Accepted
Commit b64787840080bdbd048bb9c68222ad17236cbd7e
Headers show
Series [net] selftests: tcp_ao: add a config file | expand

Commit Message

Jakub Kicinski Jan. 24, 2024, 7:25 p.m. UTC
Still a bit unclear whether each directory should have its own
config file, but assuming they should lets add one for tcp_ao.

The following tests still fail with this config in place:
 - rst_ipv4,
 - rst_ipv6,
 - bench-lookups_ipv6.
other 21 pass.

Fixes: d11301f65977 ("selftests/net: Add TCP-AO ICMPs accept test")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: shuah@kernel.org
CC: 0x7f454c46@gmail.com
CC: linux-kselftest@vger.kernel.org
---
 tools/testing/selftests/net/tcp_ao/config | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 tools/testing/selftests/net/tcp_ao/config

Comments

Dmitry Safonov Jan. 24, 2024, 8:01 p.m. UTC | #1
On 1/24/24 19:25, Jakub Kicinski wrote:
> Still a bit unclear whether each directory should have its own
> config file, but assuming they should lets add one for tcp_ao.
> 
> The following tests still fail with this config in place:
>  - rst_ipv4,
>  - rst_ipv6,
>  - bench-lookups_ipv6.
> other 21 pass.
> 
> Fixes: d11301f65977 ("selftests/net: Add TCP-AO ICMPs accept test")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Dmitry Safonov <0x7f454c46@gmail.com>

Thanks again!

> ---
> CC: shuah@kernel.org
> CC: 0x7f454c46@gmail.com
> CC: linux-kselftest@vger.kernel.org
> ---
>  tools/testing/selftests/net/tcp_ao/config | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>  create mode 100644 tools/testing/selftests/net/tcp_ao/config
> 
> diff --git a/tools/testing/selftests/net/tcp_ao/config b/tools/testing/selftests/net/tcp_ao/config
> new file mode 100644
> index 000000000000..d3277a9de987
> --- /dev/null
> +++ b/tools/testing/selftests/net/tcp_ao/config
> @@ -0,0 +1,10 @@
> +CONFIG_CRYPTO_HMAC=y
> +CONFIG_CRYPTO_RMD160=y
> +CONFIG_CRYPTO_SHA1=y
> +CONFIG_IPV6_MULTIPLE_TABLES=y
> +CONFIG_IPV6=y
> +CONFIG_NET_L3_MASTER_DEV=y
> +CONFIG_NET_VRF=y
> +CONFIG_TCP_AO=y
> +CONFIG_TCP_MD5SIG=y
> +CONFIG_VETH=m

Thanks,
           Dmitry
patchwork-bot+netdevbpf@kernel.org Jan. 26, 2024, midnight UTC | #2
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 24 Jan 2024 11:25:50 -0800 you wrote:
> Still a bit unclear whether each directory should have its own
> config file, but assuming they should lets add one for tcp_ao.
> 
> The following tests still fail with this config in place:
>  - rst_ipv4,
>  - rst_ipv6,
>  - bench-lookups_ipv6.
> other 21 pass.
> 
> [...]

Here is the summary with links:
  - [net] selftests: tcp_ao: add a config file
    https://git.kernel.org/netdev/net/c/b64787840080

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/tcp_ao/config b/tools/testing/selftests/net/tcp_ao/config
new file mode 100644
index 000000000000..d3277a9de987
--- /dev/null
+++ b/tools/testing/selftests/net/tcp_ao/config
@@ -0,0 +1,10 @@ 
+CONFIG_CRYPTO_HMAC=y
+CONFIG_CRYPTO_RMD160=y
+CONFIG_CRYPTO_SHA1=y
+CONFIG_IPV6_MULTIPLE_TABLES=y
+CONFIG_IPV6=y
+CONFIG_NET_L3_MASTER_DEV=y
+CONFIG_NET_VRF=y
+CONFIG_TCP_AO=y
+CONFIG_TCP_MD5SIG=y
+CONFIG_VETH=m