| Message ID | 20240129224542.162599-2-nphamcs@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2b2178c40747dcfc54a477dd4def4318b06d30ad |
| Headers | show |
| Series | fix and extend zswap kselftests | expand |
On Mon, Jan 29, 2024 at 02:45:40PM -0800, Nhat Pham wrote: > Make it easier for contributors to find the zswap maintainers when they > update the zswap tests. > > Signed-off-by: Nhat Pham <nphamcs@gmail.com> I guess I had to check the zswap tests at some point :) Acked-by: Yosry Ahmed <yosryahmed@google.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index fecebfc4c0dc..5f60faaefaf2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -24396,6 +24396,7 @@ F: include/linux/zpool.h > F: include/linux/zswap.h > F: mm/zpool.c > F: mm/zswap.c > +F: tools/testing/selftests/cgroup/test_zswap.c > > THE REST > M: Linus Torvalds <torvalds@linux-foundation.org> > -- > 2.39.3 >
On Mon, Jan 29, 2024 at 5:02 PM Yosry Ahmed <yosryahmed@google.com> wrote: > > On Mon, Jan 29, 2024 at 02:45:40PM -0800, Nhat Pham wrote: > > Make it easier for contributors to find the zswap maintainers when they > > update the zswap tests. > > > > Signed-off-by: Nhat Pham <nphamcs@gmail.com> > > I guess I had to check the zswap tests at some point :) We sorely need more zswap tests :) I'm one of the offenders of adding new features without including tests, so no judging anyone of course, and admittedly zswap is quite intertwined with other parts of MM, so it's kinda hard to write unit-ish tests for zswap only. I often had to resort to scripting stress tests to iron out bugs. But there are still tests that we can write to verify public API (cgroup's zswap options come to mind), simple tests that cover crucial code paths, etc. that we should probably add in. At the very least this can be a quick/sanity check for developing and backporting patches into the production system. > > Acked-by: Yosry Ahmed <yosryahmed@google.com> > > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index fecebfc4c0dc..5f60faaefaf2 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -24396,6 +24396,7 @@ F: include/linux/zpool.h > > F: include/linux/zswap.h > > F: mm/zpool.c > > F: mm/zswap.c > > +F: tools/testing/selftests/cgroup/test_zswap.c > > > > THE REST > > M: Linus Torvalds <torvalds@linux-foundation.org> > > -- > > 2.39.3 > >
On Tue, Jan 30, 2024 at 10:37:15AM -0800, Nhat Pham wrote: > On Mon, Jan 29, 2024 at 5:02 PM Yosry Ahmed <yosryahmed@google.com> wrote: > > > > On Mon, Jan 29, 2024 at 02:45:40PM -0800, Nhat Pham wrote: > > > Make it easier for contributors to find the zswap maintainers when they > > > update the zswap tests. > > > > > > Signed-off-by: Nhat Pham <nphamcs@gmail.com> > > > > I guess I had to check the zswap tests at some point :) > > We sorely need more zswap tests :) > > I'm one of the offenders of adding new features without including > tests, so no judging anyone of course, and admittedly zswap is quite > intertwined with other parts of MM, so it's kinda hard to write > unit-ish tests for zswap only. I often had to resort to scripting > stress tests to iron out bugs. > > But there are still tests that we can write to verify public API > (cgroup's zswap options come to mind), simple tests that cover crucial > code paths, etc. that we should probably add in. At the very least > this can be a quick/sanity check for developing and backporting > patches into the production system. Agreed. I am yet to take a close look at the existing tests tbh, but I took a quick look before and there is room for improvement (and little bandwidth to act on it).
diff --git a/MAINTAINERS b/MAINTAINERS index fecebfc4c0dc..5f60faaefaf2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -24396,6 +24396,7 @@ F: include/linux/zpool.h F: include/linux/zswap.h F: mm/zpool.c F: mm/zswap.c +F: tools/testing/selftests/cgroup/test_zswap.c THE REST M: Linus Torvalds <torvalds@linux-foundation.org>
Make it easier for contributors to find the zswap maintainers when they update the zswap tests. Signed-off-by: Nhat Pham <nphamcs@gmail.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)