| Message ID | 20240213142055.395564-1-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2ec197fda25f57afccac7f2846e509471488614c |
| Headers | show |
| Series | [net] selftests: tls: increase the wait in poll_partial_rec_async | expand |
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 13 Feb 2024 06:20:55 -0800 you wrote: > Test runners on debug kernels occasionally fail with: > > # # RUN tls_err.13_aes_gcm.poll_partial_rec_async ... > # # tls.c:1883:poll_partial_rec_async:Expected poll(&pfd, 1, 5) (0) == 1 (1) > # # tls.c:1870:poll_partial_rec_async:Expected status (256) == 0 (0) > # # poll_partial_rec_async: Test failed at step #17 > # # FAIL tls_err.13_aes_gcm.poll_partial_rec_async > # not ok 699 tls_err.13_aes_gcm.poll_partial_rec_async > # # FAILED: 698 / 699 tests passed. > > [...] Here is the summary with links: - [net] selftests: tls: increase the wait in poll_partial_rec_async https://git.kernel.org/netdev/net/c/2ec197fda25f You are awesome, thank you!
diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c index bc36c91c4480..49c84602707f 100644 --- a/tools/testing/selftests/net/tls.c +++ b/tools/testing/selftests/net/tls.c @@ -1874,13 +1874,13 @@ TEST_F(tls_err, poll_partial_rec_async) /* Child should sleep in poll(), never get a wake */ pfd.fd = self->cfd2; pfd.events = POLLIN; - EXPECT_EQ(poll(&pfd, 1, 5), 0); + EXPECT_EQ(poll(&pfd, 1, 20), 0); EXPECT_EQ(write(p[1], &token, 1), 1); /* Barrier #1 */ pfd.fd = self->cfd2; pfd.events = POLLIN; - EXPECT_EQ(poll(&pfd, 1, 5), 1); + EXPECT_EQ(poll(&pfd, 1, 20), 1); exit(!_metadata->passed); }
Test runners on debug kernels occasionally fail with: # # RUN tls_err.13_aes_gcm.poll_partial_rec_async ... # # tls.c:1883:poll_partial_rec_async:Expected poll(&pfd, 1, 5) (0) == 1 (1) # # tls.c:1870:poll_partial_rec_async:Expected status (256) == 0 (0) # # poll_partial_rec_async: Test failed at step #17 # # FAIL tls_err.13_aes_gcm.poll_partial_rec_async # not ok 699 tls_err.13_aes_gcm.poll_partial_rec_async # # FAILED: 698 / 699 tests passed. This points to the second poll() in the test which is expected to wait for the sender to send the rest of the data. Apparently under some conditions that doesn't happen within 5ms, bump the timeout to 20ms. Fixes: 23fcb62bc19c ("selftests: tls: add tests for poll behavior") Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: shuah@kernel.org CC: linux-kselftest@vger.kernel.org --- tools/testing/selftests/net/tls.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)