diff mbox series

[net-next,v2,1/7] netlink: specs: define ethtool header flags

Message ID 20240403023426.1762996-2-kuba@kernel.org (mailing list archive)
State Accepted
Commit 1d056bf9a4c15d433e9aa49558e58c1cf8d7f70c
Headers show
Series selftests: net: groundwork for YNL-based tests | expand

Commit Message

Jakub Kicinski April 3, 2024, 2:34 a.m. UTC
When interfacing with the ethtool commands it's handy to
be able to use the names of the flags. Example:

    ethnl.pause_get({"header": {"dev-index": cfg.ifindex,
                                "flags": {'stats'}}})

Note that not all commands accept all the flags,
but the meaning of the bits does not change command
to command.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
v2:
 - make sure we don't try to code gen enum (add enum-name:)
---
 Documentation/netlink/specs/ethtool.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Petr Machata April 4, 2024, 10:38 a.m. UTC | #1
Jakub Kicinski <kuba@kernel.org> writes:

> When interfacing with the ethtool commands it's handy to
> be able to use the names of the flags. Example:
>
>     ethnl.pause_get({"header": {"dev-index": cfg.ifindex,
>                                 "flags": {'stats'}}})
>
> Note that not all commands accept all the flags,
> but the meaning of the bits does not change command
> to command.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Petr Machata <petrm@nvidia.com>
diff mbox series

Patch

diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index 197208f419dc..d0e4a47e0f21 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -16,6 +16,11 @@  doc: Partial family for Ethtool Netlink.
     name: stringset
     type: enum
     entries: []
+  -
+    name: header-flags
+    enum-name:
+    type: flags
+    entries: [ compact-bitsets, omit-reply, stats ]
 
 attribute-sets:
   -
@@ -30,6 +35,7 @@  doc: Partial family for Ethtool Netlink.
       -
         name: flags
         type: u32
+        enum: header-flags
 
   -
     name: bitset-bit