| Message ID | 20240429234610.191144-1-edliaw@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | eb59a58113717df04b8a8229befd8ab1e5dbf86e |
| Headers | show |
| Series | selftests/kcmp: Remove unused open mode | expand |
On Mon, Apr 29, 2024 at 11:46:09PM +0000, Edward Liaw wrote: > Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE > aren't specified. The permissions for the file are set above: > > fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644); > > Fixes: d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall") > Signed-off-by: Edward Liaw <edliaw@google.com> Thanks! Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>
diff --git a/tools/testing/selftests/kcmp/kcmp_test.c b/tools/testing/selftests/kcmp/kcmp_test.c index 25110c7c0b3e..d7a8e321bb16 100644 --- a/tools/testing/selftests/kcmp/kcmp_test.c +++ b/tools/testing/selftests/kcmp/kcmp_test.c @@ -91,7 +91,7 @@ int main(int argc, char **argv) ksft_print_header(); ksft_set_plan(3); - fd2 = open(kpath, O_RDWR, 0644); + fd2 = open(kpath, O_RDWR); if (fd2 < 0) { perror("Can't open file"); ksft_exit_fail();
Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE aren't specified. The permissions for the file are set above: fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644); Fixes: d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall") Signed-off-by: Edward Liaw <edliaw@google.com> --- tools/testing/selftests/kcmp/kcmp_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)