| Message ID | 20240509200022.253089-28-edliaw@google.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Define _GNU_SOURCE for sources using | expand |
On Thu, May 09, 2024 at 07:58:19PM +0000, Edward Liaw wrote: > _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent > redefinition warnings. > > Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") > Reviewed-by: John Hubbard <jhubbard@nvidia.com> > Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > Signed-off-by: Edward Liaw <edliaw@google.com> Please only remove lines with _GNU_SOURCE, not the empty lines. I think it would be better to not change such style choice for other subsystems too. With this change for the Landlock selftests: Acked-by: Mickaël Salaün <mic@digikod.net> > --- > tools/testing/selftests/landlock/base_test.c | 2 -- > tools/testing/selftests/landlock/fs_test.c | 2 -- > tools/testing/selftests/landlock/net_test.c | 2 -- > tools/testing/selftests/landlock/ptrace_test.c | 2 -- > 4 files changed, 8 deletions(-) > > diff --git a/tools/testing/selftests/landlock/base_test.c b/tools/testing/selftests/landlock/base_test.c > index 3c1e9f35b531..c86e6f87b398 100644 > --- a/tools/testing/selftests/landlock/base_test.c > +++ b/tools/testing/selftests/landlock/base_test.c > @@ -5,8 +5,6 @@ > * Copyright © 2017-2020 Mickaël Salaün <mic@digikod.net> > * Copyright © 2019-2020 ANSSI > */ > - > -#define _GNU_SOURCE > #include <errno.h> > #include <fcntl.h> > #include <linux/landlock.h> > diff --git a/tools/testing/selftests/landlock/fs_test.c b/tools/testing/selftests/landlock/fs_test.c > index 6b5a9ff88c3d..eec0d9a44d50 100644 > --- a/tools/testing/selftests/landlock/fs_test.c > +++ b/tools/testing/selftests/landlock/fs_test.c > @@ -6,8 +6,6 @@ > * Copyright © 2020 ANSSI > * Copyright © 2020-2022 Microsoft Corporation > */ > - > -#define _GNU_SOURCE > #include <asm/termbits.h> > #include <fcntl.h> > #include <libgen.h> > diff --git a/tools/testing/selftests/landlock/net_test.c b/tools/testing/selftests/landlock/net_test.c > index f21cfbbc3638..eed040adcbac 100644 > --- a/tools/testing/selftests/landlock/net_test.c > +++ b/tools/testing/selftests/landlock/net_test.c > @@ -5,8 +5,6 @@ > * Copyright © 2022-2023 Huawei Tech. Co., Ltd. > * Copyright © 2023 Microsoft Corporation > */ > - > -#define _GNU_SOURCE > #include <arpa/inet.h> > #include <errno.h> > #include <fcntl.h> > diff --git a/tools/testing/selftests/landlock/ptrace_test.c b/tools/testing/selftests/landlock/ptrace_test.c > index a19db4d0b3bd..c831e6d03b02 100644 > --- a/tools/testing/selftests/landlock/ptrace_test.c > +++ b/tools/testing/selftests/landlock/ptrace_test.c > @@ -5,8 +5,6 @@ > * Copyright © 2017-2020 Mickaël Salaün <mic@digikod.net> > * Copyright © 2019-2020 ANSSI > */ > - > -#define _GNU_SOURCE > #include <errno.h> > #include <fcntl.h> > #include <linux/landlock.h> > -- > 2.45.0.118.g7fe29c98d7-goog > >
diff --git a/tools/testing/selftests/landlock/base_test.c b/tools/testing/selftests/landlock/base_test.c index 3c1e9f35b531..c86e6f87b398 100644 --- a/tools/testing/selftests/landlock/base_test.c +++ b/tools/testing/selftests/landlock/base_test.c @@ -5,8 +5,6 @@ * Copyright © 2017-2020 Mickaël Salaün <mic@digikod.net> * Copyright © 2019-2020 ANSSI */ - -#define _GNU_SOURCE #include <errno.h> #include <fcntl.h> #include <linux/landlock.h> diff --git a/tools/testing/selftests/landlock/fs_test.c b/tools/testing/selftests/landlock/fs_test.c index 6b5a9ff88c3d..eec0d9a44d50 100644 --- a/tools/testing/selftests/landlock/fs_test.c +++ b/tools/testing/selftests/landlock/fs_test.c @@ -6,8 +6,6 @@ * Copyright © 2020 ANSSI * Copyright © 2020-2022 Microsoft Corporation */ - -#define _GNU_SOURCE #include <asm/termbits.h> #include <fcntl.h> #include <libgen.h> diff --git a/tools/testing/selftests/landlock/net_test.c b/tools/testing/selftests/landlock/net_test.c index f21cfbbc3638..eed040adcbac 100644 --- a/tools/testing/selftests/landlock/net_test.c +++ b/tools/testing/selftests/landlock/net_test.c @@ -5,8 +5,6 @@ * Copyright © 2022-2023 Huawei Tech. Co., Ltd. * Copyright © 2023 Microsoft Corporation */ - -#define _GNU_SOURCE #include <arpa/inet.h> #include <errno.h> #include <fcntl.h> diff --git a/tools/testing/selftests/landlock/ptrace_test.c b/tools/testing/selftests/landlock/ptrace_test.c index a19db4d0b3bd..c831e6d03b02 100644 --- a/tools/testing/selftests/landlock/ptrace_test.c +++ b/tools/testing/selftests/landlock/ptrace_test.c @@ -5,8 +5,6 @@ * Copyright © 2017-2020 Mickaël Salaün <mic@digikod.net> * Copyright © 2019-2020 ANSSI */ - -#define _GNU_SOURCE #include <errno.h> #include <fcntl.h> #include <linux/landlock.h>
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent redefinition warnings. Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") Reviewed-by: John Hubbard <jhubbard@nvidia.com> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Signed-off-by: Edward Liaw <edliaw@google.com> --- tools/testing/selftests/landlock/base_test.c | 2 -- tools/testing/selftests/landlock/fs_test.c | 2 -- tools/testing/selftests/landlock/net_test.c | 2 -- tools/testing/selftests/landlock/ptrace_test.c | 2 -- 4 files changed, 8 deletions(-)