diff mbox series

[v4,37/66] selftests/nolibc: Drop define _GNU_SOURCE

Message ID	20240510000842.410729-38-edliaw@google.com (mailing list archive)
State	New
Headers	show Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06BAB1369A4 for <linux-kselftest@vger.kernel.org>; Fri, 10 May 2024 00:10:52 +0000 (UTC) Date: Fri, 10 May 2024 00:06:54 +0000 In-Reply-To: <20240510000842.410729-1-edliaw@google.com> Precedence: bulk Mime-Version: 1.0 References: <20240510000842.410729-1-edliaw@google.com> Message-ID: <20240510000842.410729-38-edliaw@google.com> Subject: [PATCH v4 37/66] selftests/nolibc: Drop define _GNU_SOURCE From: Edward Liaw <edliaw@google.com> To: shuah@kernel.org, " =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= " <mic@digikod.net>, " =?utf-8?q?G?= =?utf-8?q?=C3=BCnther_Noack?= " <gnoack@google.com>, Christian Brauner <brauner@kernel.org>, Richard Cochran <richardcochran@gmail.com>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Jesper Dangaard Brouer <hawk@kernel.org>, John Fastabend <john.fastabend@gmail.com>, Willy Tarreau <w@1wt.eu>, " =?utf-8?q?Thomas_Wei=C3=9Fschuh?= " <linux@weissschuh.net> Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, Edward Liaw <edliaw@google.com>, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8"
Series	Define _GNU_SOURCE for sources using \| expand [v4,00/66] Define _GNU_SOURCE for sources using [v4,01/66] selftests: Compile with -D_GNU_SOURCE when including lib.mk [v4,02/66] selftests/arm64: Drop define _GNU_SOURCE [v4,03/66] selftests/arm64: Drop duplicate -D_GNU_SOURCE [v4,04/66] selftests/bpf: Drop define _GNU_SOURCE [v4,05/66] selftests/breakpoints: Drop define _GNU_SOURCE [v4,06/66] selftests/cachestat: Drop define _GNU_SOURCE [v4,07/66] selftests/capabilities: Drop define _GNU_SOURCE [v4,08/66] selftests/cgroup: Drop define _GNU_SOURCE [v4,09/66] selftests/clone3: Drop define _GNU_SOURCE [v4,10/66] selftests/core: Drop define _GNU_SOURCE [v4,11/66] selftests/damon: Drop define _GNU_SOURCE [v4,12/66] selftests/drivers: Drop define _GNU_SOURCE [v4,13/66] selftests/exec: Drop duplicate -D_GNU_SOURCE [v4,14/66] selftests/fchmodat2: Drop define _GNU_SOURCE [v4,15/66] selftests/filelock: Drop define _GNU_SOURCE [v4,16/66] selftests/filesystems: Drop define _GNU_SOURCE [v4,17/66] selftests/firmware: Drop define _GNU_SOURCE [v4,18/66] selftests/fpu: Drop define _GNU_SOURCE [v4,19/66] selftests/futex: Drop define _GNU_SOURCE [v4,20/66] selftests/futex: Drop duplicate -D_GNU_SOURCE [v4,21/66] selftests/intel_pstate: Drop duplicate -D_GNU_SOURCE [v4,22/66] selftests/iommu: Drop duplicate -D_GNU_SOURCE [v4,23/66] selftests/ipc: Drop define _GNU_SOURCE [v4,24/66] selftests/kcmp: Drop define _GNU_SOURCE [v4,25/66] selftests/landlock: Drop define _GNU_SOURCE [v4,26/66] selftests/lsm: Drop define _GNU_SOURCE [v4,27/66] selftests/membarrier: Drop define _GNU_SOURCE [v4,28/66] selftests/memfd: Drop define _GNU_SOURCE [v4,29/66] selftests/mincore: Drop define _GNU_SOURCE [v4,30/66] selftests/mm: Drop define _GNU_SOURCE [v4,31/66] selftests/mount: Drop define _GNU_SOURCE [v4,32/66] selftests/mount_setattr: Drop define _GNU_SOURCE [v4,33/66] selftests/move_mount_set_group: Drop define _GNU_SOURCE [v4,34/66] selftests/mqueue: Drop define _GNU_SOURCE [v4,35/66] selftests/net: Drop define _GNU_SOURCE [v4,36/66] selftests/net: Drop duplicate -D_GNU_SOURCE [v4,37/66] selftests/nolibc: Drop define _GNU_SOURCE [v4,38/66] selftests/nsfs: Drop define _GNU_SOURCE [v4,39/66] selftests/openat2: Drop define _GNU_SOURCE [v4,40/66] selftests/perf_events: Drop define _GNU_SOURCE [v4,41/66] selftests/pid_namespace: Drop define _GNU_SOURCE [v4,42/66] selftests/pidfd: Drop define _GNU_SOURCE [v4,43/66] selftests/ptrace: Drop define _GNU_SOURCE [v4,44/66] selftests/powerpc: Drop define _GNU_SOURCE [v4,45/66] selftests/proc: Drop define _GNU_SOURCE [v4,46/66] selftests/proc: Drop duplicate -D_GNU_SOURCE [v4,47/66] selftests/ptp: Drop define _GNU_SOURCE [v4,48/66] selftests/resctrl: Drop duplicate -D_GNU_SOURCE [v4,49/66] selftests/riscv: Drop define _GNU_SOURCE [v4,50/66] selftests/riscv: Drop duplicate -D_GNU_SOURCE [v4,51/66] selftests/rlimits: Drop define _GNU_SOURCE [v4,52/66] selftests/rseq: Drop define _GNU_SOURCE [v4,53/66] selftests/safesetid: Drop define _GNU_SOURCE [v4,54/66] selftests/sched: Drop define _GNU_SOURCE [v4,55/66] selftests/seccomp: Drop define _GNU_SOURCE [v4,56/66] selftests/sigaltstack: Drop define _GNU_SOURCE [v4,57/66] selftests/splice: Drop define _GNU_SOURCE [v4,58/66] selftests/syscall_user_dispatch: Drop define _GNU_SOURCE [v4,59/66] selftests/thermal: Drop define _GNU_SOURCE [v4,60/66] selftests/timens: Drop define _GNU_SOURCE [v4,61/66] selftests/tmpfs: Drop duplicate -D_GNU_SOURCE [v4,62/66] selftests/uevent: Drop define _GNU_SOURCE [v4,63/66] selftests/user_events: Drop define _GNU_SOURCE [v4,64/66] selftests/vDSO: Drop define _GNU_SOURCE [v4,65/66] selftests/wireguard: Drop define _GNU_SOURCE [v4,66/66] selftests/x86: Drop define _GNU_SOURCE

Commit Message

Edward Liaw May 10, 2024, 12:06 a.m. UTC

_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.

Signed-off-by: Edward Liaw <edliaw@google.com>
---
 tools/testing/selftests/nolibc/nolibc-test.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Thomas Weißschuh May 10, 2024, 6:58 a.m. UTC | #1

Hi Edward,

On 2024-05-10 00:06:54+0000, Edward Liaw wrote:
> _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
> redefinition warnings.

The nolibc tests do not use lib.mk.

This change breaks "make libc-test", please drop it.

> Signed-off-by: Edward Liaw <edliaw@google.com>
> ---
>  tools/testing/selftests/nolibc/nolibc-test.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> index 94bb6e11c16f..a28813f4367f 100644
> --- a/tools/testing/selftests/nolibc/nolibc-test.c
> +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> @@ -1,6 +1,4 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
> -
> -#define _GNU_SOURCE
>  #define _LARGEFILE64_SOURCE
>  
>  /* libc-specific include files
> -- 
> 2.45.0.118.g7fe29c98d7-goog

Thomas

diff mbox series

Patch

diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
index 94bb6e11c16f..a28813f4367f 100644
--- a/tools/testing/selftests/nolibc/nolibc-test.c
+++ b/tools/testing/selftests/nolibc/nolibc-test.c
@@ -1,6 +1,4 @@ 
 /* SPDX-License-Identifier: GPL-2.0 */
-
-#define _GNU_SOURCE
 #define _LARGEFILE64_SOURCE
 
 /* libc-specific include files